Merge pull request #185 from matt439/fix-replace-all

Fix bug in replace_all
splashkit · Oct 18, 2024 · 137488c · 137488c
2 parents aece11b + de8be75
commit 137488c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/coresdk/src/coresdk/basics.cpp b/coresdk/src/coresdk/basics.cpp
@@ -76,6 +76,9 @@ namespace splashkit_lib
 
     string replace_all(const string &text, const string &substr, const string &replacement)
     {
+        if (substr.empty())
+            return text;
+
         string result = text;
         size_t pos = 0;
         while ((pos = result.find(substr, pos)) != string::npos)

diff --git a/coresdk/src/test/test_text.cpp b/coresdk/src/test/test_text.cpp
@@ -117,6 +117,7 @@ void test_string_utils()
     cout << "To lower of " << mixedText << " is " << to_lowercase(mixedText) << endl;
     cout << "Trim of " << mixedText << " is " << trim(mixedText) << endl;
     cout << "Replace all of " << mixedText << " is " << replace_all(mixedText, " ", "_") << endl;
+    cout << "Replace all of " << mixedText << " when substring is empty is " << replace_all(mixedText, "", "_") << endl;
 
     vector<string> vec = split(mixedText, ' ');