-
Notifications
You must be signed in to change notification settings - Fork 632
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(signalfx): Fixed metric type missing due to duplicated field from…
… parent class (#957) (#958) (cherry picked from commit 179492b) Co-authored-by: Jason <[email protected]>
- Loading branch information
1 parent
bc7e3bf
commit d2a4c79
Showing
2 changed files
with
54 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
...ta-signalfx/src/test/java/com/netflix/kayenta/signalfx/config/SignalFxConfigLoadTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
/* | ||
* Copyright 2023 Armory, Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.netflix.kayenta.signalfx.config; | ||
|
||
import static junit.framework.TestCase.assertEquals; | ||
import static org.mockito.Mockito.mock; | ||
import static org.mockito.Mockito.when; | ||
|
||
import com.netflix.kayenta.retrofit.config.RetrofitClientFactory; | ||
import com.netflix.kayenta.security.AccountCredentials; | ||
import com.netflix.kayenta.security.AccountCredentialsRepository; | ||
import com.netflix.kayenta.security.MapBackedAccountCredentialsRepository; | ||
import com.squareup.okhttp.OkHttpClient; | ||
import java.util.List; | ||
import org.junit.Test; | ||
|
||
public class SignalFxConfigLoadTest { | ||
|
||
private AccountCredentialsRepository accountRepo = new MapBackedAccountCredentialsRepository(); | ||
|
||
@Test | ||
public void testThatConfigLoadFromAccountRendersCorrectly() { | ||
SignalFxConfigurationProperties signalFxConfigurationProperties = | ||
mock(SignalFxConfigurationProperties.class); | ||
when(signalFxConfigurationProperties.getAccounts()) | ||
.thenReturn(List.of(new SignalFxManagedAccount().setName("Test-account"))); | ||
RetrofitClientFactory mockRetrofitFactory = mock(RetrofitClientFactory.class); | ||
OkHttpClient mockOkHttpFactory = mock(OkHttpClient.class); | ||
new SignalFxConfiguration() | ||
.signalFxMetricService( | ||
signalFxConfigurationProperties, mockRetrofitFactory, mockOkHttpFactory, accountRepo); | ||
assertEquals("signalfx", accountRepo.getRequiredOne("Test-account").getType()); | ||
assertEquals( | ||
List.of(AccountCredentials.Type.METRICS_STORE), | ||
accountRepo.getRequiredOne("Test-account").getSupportedTypes()); | ||
} | ||
} |