Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(kubernetes): convert scale manifest stage to react #10151

Conversation

cristhian-castaneda
Copy link
Member

Overview

This PR addresses the refactoring of the Scale (Manifest) stage, part of the ongoing effort to transition Kubernetes stages to React. For additional context, please refer to spinnaker/spinnaker#4254

Changes Made

  • Refactored Components:
    • The files scaleManifestConfig.html and scaleManifestConfig.controller.ts have been converted into the new components ScaleManifestConfig.tsx and ScaleManifestStageForm.tsx.
    • The file scaleSettingsForm.component.ts has been converted into the new ScaleSettingsForm.tsx component. Note that this component is also used in /manifest/scale/scale.html for the ad-hoc scale form, so it needs to be portable via react2angular until this angular template is converted to React.
    • The scale.controller.ts and scale.html files were adapted to use the new react-based component.

UI Views

Stage Config

image

Execution Details Sections

Scale Manifest

image

Execution Details Tasks

image

Scale form

image

@mattgogerly
Copy link
Member

@Mergifyio update

@mattgogerly mattgogerly added the ready to merge Reviewed and ready for merge label Dec 2, 2024
Copy link
Contributor

mergify bot commented Dec 2, 2024

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/sync-secrets.yml without workflows permission

@mergify mergify bot added the auto merged Merged automatically by a bot label Dec 2, 2024
@mergify mergify bot merged commit 269b738 into spinnaker:master Dec 2, 2024
4 checks passed
@cristhian-castaneda cristhian-castaneda deleted the refactor/reactify-scale-manifest-stage branch December 3, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.37
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants