feat(google): add support for partnerMetadata in GCE servergroup #10150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarulg
requested review from
jasonmcintosh,
link108,
christosarvanitis and
dbyron-sf
link108
approved these changes
Oct 21, 2024
edgarulg
added
ready to merge
christosarvanitis
pushed a commit
to armory-io/deck
that referenced
this pull request
Nov 12, 2024
…nnaker#10150) * feat(google): add support for partnerMetadata in GCE servergroup * feat(google): fix prettier issues * feat(google): render JSON object as its string representation * feat(google): update tests with textarea * feat(google): fix prettier issue * feat(google): move display logic to controller * feat(google): fix tests * feat(google): expect JSON string in test * feat(google): use formatValueForDisplay in ng-model * feat(google): define json-text directive to handle view * feat(google): add space to JSON format * feat(google): remove hiddenKeys test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Partner Metadata field in GCE server group.
Partner Metadata is a Key Value Pair but the value needs to be a JSON object. In order to achieve this format in UI I defined a new component in angular named mapObjectEditor. It provides a textarea for the value to allow user to write/paste their JSON object.
Then, the partnerMetadata is included in the pipeline configuration as a JSON object. This is expected for the backend (clouddriver).
Issue related: spinnaker/spinnaker#6931
clouddriver PR related: spinnaker/clouddriver#6297
Kork PR related: spinnaker/kork#1208