fix(aws): Fix IPv6 addresses being incorrectly associated when cloning server groups that have launch templates enabled (#6979)

[ashleykleynhans]

This is a fix for #6979.

The IPv6 checkbox was previously checked when it should not have been.

This line:

associateIPv6Address: shouldAutoEnableIPv6 || Boolean(ipv6AddressCount),

Was casting the entire object below to Boolean, which ALWAYS resulted in a value of true:

[
  {
    "deviceIndex": 0,
    "groups": [
      "sg-0a1a8a45acf3192b8"
    ],
    "ipv4Prefixes": [],
    "ipv6AddressCount": 0,
    "ipv6Addresses": [],
    "ipv6Prefixes": [],
    "privateIpAddresses": []
  }
]

The change casts the value of ipv6AddressCount within the object to Boolean instead of the object itself.

[dbyron-sf]

Thanks for this @ashleykleynhans . I suspect this is the right fix. What's involved in writing an automated test to demonstrate the bug + fix?

[ashleykleynhans]

@dbyron-sf unfortunately I have no idea, frontend is not one of my strengths, I am a backend person. This bug has just not been fixed in about 2 years so I figured nobody is going to fix it and had to fix it myself.

[dbyron-sf]

Fair enough. I had to ask :)

[ashleykleynhans]

There may already be some kind of test for it, because my first attempt failed a test and I had to make a change to get it to pass the test.

[dbyron-sf]

@Mergifyio backport release-1.35.x

[mergify]

backport release-1.35.x

✅ Backports have been created

• #10144 fix(aws): Fix IPv6 addresses being incorrectly associated when cloning server groups that have launch templates enabled (#6979) (backport #10142) has been created for branch release-1.35.x