Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Add ability to set Default Tag filters for an application… #10020

Merged
merged 3 commits into from
Aug 31, 2023
Merged

feat(core): Add ability to set Default Tag filters for an application… #10020

merged 3 commits into from
Aug 31, 2023

Conversation

bliu2368
Copy link
Contributor

@bliu2368 bliu2368 commented Aug 29, 2023 •
edited
Loading

… in application config

Summary:

  • Added section in Application Config which allows users to define "Default Filters" for their pipelines page.
  • Each of these Default Filters will automatically be applied when opening the pipelines page, they can still be temporarily disabled
  • Currently only supports filtering by tag (which can be set per pipeline)
  • Added tests

Most of the code changes were based on how bannerConfig was written, so follows the patterns used there. (e.g. the tests are practically identical)

Brief Demo:

Loom.Message.-.28.August.2023.mp4

@mattgogerly
Copy link
Member

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2023

update

✅ Branch has been successfully updated

@mattgogerly mattgogerly added the ready to merge Reviewed and ready for merge label Aug 31, 2023
@mergify mergify bot added the auto merged Merged automatically by a bot label Aug 31, 2023
@mergify mergify bot merged commit c768e88 into spinnaker:master Aug 31, 2023
4 checks passed
sahititarigoppula pushed a commit to OpsMx/deck-oes that referenced this pull request Jun 5, 2024
@bliu2368 @mergify @sahititarigoppula
feat(core): Add ability to set Default Tag filters for an application…
e13dda5 
… in application config (spinnaker#10020)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattgogerly mattgogerly mattgogerly approved these changes

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.33
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bliu2368 @mattgogerly @spinnakerbot