fix: Scaling bounds should parse float not int (#10026) (#10032)

* fix: Scaling bounds should parse float not int Currently the API can do this, the model supports this, but the parseInt removes decimals from the UI * fix: Decimal support for upper/lower bound ASG tests (cherry picked from commit b763cae) Co-authored-by: Jason <[email protected]>
spinnaker · Sep 26, 2023 · 69db5b3 · 69db5b3
1 parent 734c895
commit 69db5b3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/packages/amazon/src/serverGroup/details/scalingPolicy/upsert/step/StepPolicyAction.tsx b/packages/amazon/src/serverGroup/details/scalingPolicy/upsert/step/StepPolicyAction.tsx
@@ -107,7 +107,7 @@ export const StepPolicyAction = ({
                   value={step.metricIntervalLowerBound}
                   max={step.metricIntervalUpperBound}
                   onChange={(e) =>
-                    updateStep({ ...step, metricIntervalLowerBound: Number.parseInt(e.target.value) }, index)
+                    updateStep({ ...step, metricIntervalLowerBound: Number.parseFloat(e.target.value) }, index)
                   }
                   inputClassName="action-input"
                 />
@@ -122,7 +122,7 @@ export const StepPolicyAction = ({
                   value={step.metricIntervalUpperBound}
                   min={step.metricIntervalLowerBound}
                   onChange={(e) =>
-                    updateStep({ ...step, metricIntervalUpperBound: Number.parseInt(e.target.value) }, index)
+                    updateStep({ ...step, metricIntervalUpperBound: Number.parseFloat(e.target.value) }, index)
                   }
                   inputClassName="action-input"
                 />

diff --git a/packages/ecs/src/serverGroup/serverGroup.transformer.spec.ts b/packages/ecs/src/serverGroup/serverGroup.transformer.spec.ts
@@ -159,7 +159,16 @@ describe('ecsServerGroupTransformer', () => {
           [-5, 10, 0],
         );
       });
-
+      it('verify float adjustments work within the range', function () {
+        this.test(
+          [
+            { id: 1, scalingAdjustment: 10, metricIntervalLowerBound: 3.5, metricIntervalUpperBound: 5.5 },
+            { id: 2, scalingAdjustment: 0, metricIntervalLowerBound: 5.5 },
+            { id: 3, scalingAdjustment: -5, metricIntervalLowerBound: 1.2, metricIntervalUpperBound: 3.5 },
+          ],
+          [-5, 10, 0],
+        );
+      });
       it('reverse sorts step adjustments by upper bound when all have an upper bound defined', function () {
         this.test(
           [