feat(evaluateVariables stage) Made fetch exec history on evaluateVari…

…ables stage configurable (#10143) * feat(evaluateVariables stage): Made fetch exec history on evaluateVariables stage configurable * feat(evaluateVariables stage): fixed prettier violation --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
spinnaker · Sep 12, 2024 · 08b95df · 08b95df
1 parent 77dd8bf
commit 08b95df
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/packages/app/src/settings.js b/packages/app/src/settings.js
@@ -148,6 +148,7 @@ window.spinnakerSettings = {
     defaultManifest: 'spinnaker.yml',
     manifestBasePath: '.spinnaker',
   },
+  maxFetchHistoryOnEvaluateVariables: 100,
   maxPipelineAgeDays: 14,
   newApplicationDefaults: {
     chaosMonkey: false,

diff --git a/packages/core/src/config/settings.ts b/packages/core/src/config/settings.ts
@@ -127,6 +127,7 @@ export interface ISpinnakerSettings {
     manifestBasePath: string;
     urls?: Partial<IManagedDeliveryURLs>;
   };
+  maxFetchHistoryOnEvaluateVariables?: number;
   maxPipelineAgeDays: number;
   newApplicationDefaults: INewApplicationDefaults;
   notifications: INotificationSettings;
@@ -175,6 +176,7 @@ SETTINGS.managedDelivery = SETTINGS.managedDelivery || {
   defaultManifest: 'spinnaker.yml',
   manifestBasePath: '.spinnaker',
 };
+SETTINGS.maxFetchHistoryOnEvaluateVariables = SETTINGS.maxFetchHistoryOnEvaluateVariables ?? 100;
 
 // A helper to make resetting settings to steady state after running tests easier
 const originalSettings: ISpinnakerSettings = cloneDeep(SETTINGS);

diff --git a/packages/core/src/pipeline/config/stages/evaluateVariables/ExecutionAndStagePicker.tsx b/packages/core/src/pipeline/config/stages/evaluateVariables/ExecutionAndStagePicker.tsx
@@ -2,6 +2,7 @@ import { isEqual, keyBy } from 'lodash';
 import React from 'react';
 import type { Option } from 'react-select';
 
+import { SETTINGS } from '../../../../config';
 import type { IExecution, IPipeline, IStage } from '../../../../domain';
 import type { IStageForSpelPreview } from '../../../../presentation';
 import { FormField, ReactSelectInput, useData } from '../../../../presentation';
@@ -23,7 +24,10 @@ export function ExecutionAndStagePicker(props: IExecutionAndStagePickerProps) {
   const [showStageSelector, setShowStageSelector] = React.useState(false);
 
   const fetchExecutions = useData(
-    () => executionService.getExecutionsForConfigIds([pipeline.id], { limit: 100 }),
+    () =>
+      executionService.getExecutionsForConfigIds([pipeline.id], {
+        limit: SETTINGS.maxFetchHistoryOnEvaluateVariables,
+      }),
     [],
     [],
   );