#269 Support multiple UnionJsonKeyValue annotations for a factory

spideythewebhead · Mar 30, 2023 · 2e2884b · 2e2884b
1 parent 7080861
commit 2e2884b
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 9 deletions.
diff --git a/package/lib/src/backend/core/generators/union_from_json.dart b/package/lib/src/backend/core/generators/union_from_json.dart
@@ -38,22 +38,30 @@ class UnionFromJsonGenerator implements Generator {
       ..writeln("switch (json['$unionJsonKey']) {");
 
     for (final ConstructorDeclaration ctor in _factoriesWithRedirectedConstructors) {
-      String? jsonKeyValue =
-          AnnotationValueExtractor(ctor.metadata.getAnnotation(AnnotationType.unionJsonKeyValue))
-              .getPositionedArgument(0)
-              ?.toSource();
-
       if (ctor.name!.lexeme == unionFallbackJsonValue) {
         defaultFallbackConstructor =
             '${ctor.redirectedConstructor!.beginToken.lexeme}$_classTypeParametersSource';
         // this will be included on the default branch
         continue;
       }
 
-      _codeWriter
-        ..writeln('case ${jsonKeyValue ?? "'${ctor.name!.lexeme}'"}:')
-        ..writeln(
-            'return ${ctor.redirectedConstructor!.beginToken.lexeme}$_classTypeParametersSource.fromJson(json);');
+      final List<Annotation> unionJsonKeyValueAnnotations =
+          ctor.metadata.getAllAnnotationsByType(AnnotationType.unionJsonKeyValue);
+      for (final Annotation annotation in unionJsonKeyValueAnnotations) {
+        final String? jsonKeyValue =
+            AnnotationValueExtractor(annotation).getPositionedArgument(0)?.toSource();
+        if (jsonKeyValue == null) {
+          continue;
+        }
+        _codeWriter.writeln('case $jsonKeyValue:');
+      }
+
+      if (unionJsonKeyValueAnnotations.isEmpty) {
+        _codeWriter.writeln("case '${ctor.name}':");
+      }
+
+      _codeWriter.writeln(
+          'return ${ctor.redirectedConstructor!.beginToken.lexeme}$_classTypeParametersSource.fromJson(json);');
     }
 
     if (unionFallbackJsonValue != null && defaultFallbackConstructor == null) {

diff --git a/package/lib/src/extensions/annotation_extensions.dart b/package/lib/src/extensions/annotation_extensions.dart
@@ -86,6 +86,10 @@ extension AnnotationNodeListX on NodeList<Annotation> {
     return firstWhereOrNull((Annotation a) => a.name.name == annotation.name);
   }
 
+  List<Annotation> getAllAnnotationsByType(AnnotationType annotation) {
+    return where((Annotation a) => a.name.name == annotation.name).toList(growable: false);
+  }
+
   List<Annotation> get annotations {
     return where((Annotation annotation) {
       return AnnotationType.values