Support for loading from a directory tree where each file represents one setting

[flugeldoo]

I've added a ReadDir method that loads configuration from a directory tree. Each file in the tree is treated as a single setting: the filename is the key, and the file contents are the value. E.g.:

/config -- name (file contents: Skadi)
      |
      +--- debug (file contents: true)
      |
      +--- service -- port (file contents: 1234)
                 |
                 +--- ip (file contents: 1.2.3.4)

Calling ReadDir("/config") would produce the following configuration:

name=Skadi
debug=true
service.port=1234
service.ip=1.2.3.4

No idea if you'll find this useful, but I thought I'd send it your way nonetheless.

[flugeldoo]

Actually this should use discovery instead of reading from a given directory. Instead of ReadDir("/config") you'd do:

AddConfigPath("/config")
ReadInConfigDir()

[kzvezdarov]

What use case does this satisfy?

[philk]

We're looking for this because of the way kubernetes handles secret distribution. Basically it mounts a volume into the container with the secrets exposed as files.

[kzvezdarov]

Sounds good. There is an in-progress PR for supporting cascading config files, it might be good to coordinate the two though I am not sure yet how (and if ) it would make sense to combine them.

[flugeldoo]

Support for cascading configs will be great, especially since it means we could use kubernetes volumes for secrets, and JSON/YAML for other config. I'll take a look at that diff and see how the two might interact.

[spf13]

If we can marry these two together I think we’ve got an extremely powerful and useful tool. Just need to be mindful of how this interacts with nesting.

[flugeldoo]

I've merged the changes from wrobbins cascading configs branch. I'd like to take a closer look before claiming any of this still works though.

At some point it might be nice to reorganize viper.go too—it's getting pretty long—but not in this branch.

[spf13]

@niccaluim Do you think this is ready for review/merge?

[spf13]

@niccaluim PING :)

[cynipe]

any progress on this?

[spf13]

Until the CLA is signed, this is stalled.

@niccaluim would need to sign it at https://cla-assistant.io/spf13/viper?pullRequest=94

Then someone can try to merge this in and test it.

[spf13]

@niccaluim can you sign the CLA https://cla-assistant.io/spf13/viper?pullRequest=94 so we can take over this PR and incorporate it into Viper?

[flugeldoo]

Hey there, sorry. I'll sign it just as soon as I get the ok from Legal.

[flugeldoo]

Alright, it's signed! Does it normally take a while for the check to update?

[spf13]

Not usually. Try this link instead https://cla-assistant.io/spf13/viper . If it says you are good then you are already signed.

[flugeldoo]

Hmm, that doesn't seem to be working either. It shows me the CLA, I click to sign, it says I've signed and redirects me.

[spf13]

Thanks for being patient. I've checked in the CLA backend and you have indeed signed it. Not sure why the PR isn't updating, but it's all good. Thanks!

[vinodmut]

Are there any updates on this? As mentioned earlier in the thread, it's useful for reading Kubernetes secrets.

[titpetric]

This is becoming more relevant. Docker introspection feature is being implemented in the same way, currently it's slated as experimental, but might land in the following months. Related issue here

[Ilyes512]

So this would have been nice to have? This was opened on Jul 15, 2015!? @spf13 I notice this with more of your (awesome) opensource projects (lots of open issue's and merge requests). A little disappointed but very understandable... time is limited. To bad we don't have the option to clone our selfs :)

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Bill Robbins
❌ wrobbins

---

Bill Robbins seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[kolaente]

Any updates on this considering it's been open since quite a while? There's now even an issue about this: #1022

[jedahan]

Would love to see this implemented to support the same use case - docker secrets