-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat 52 search by genre #80
base: main
Are you sure you want to change the base?
Conversation
@spezifisch There are conflicts between my PRs, because I keep forking them off main and they often overlap files. When it's too obvious to me that merges are going to be hard this way, I'll branch off another of my unmerged branches, but this has its own problems. I have a suggestion: when you're next ready, tell me which of the PRs you would like to merge. I'll create a merge branch off main, merge and resolve the conflicts, and you can take a look at it, test run it, and pull them in at once without having to deal with the conflicts. |
Let's try that. I've just been through PRs and want to weed out the performance bugs on my setup next. |
…ned. It still queries in batches of 20, and updates the list(s) as results are available.
fix: make sure _something_ other than the search field gets focused on Enter
25aded6
to
5cac4ac
Compare
Yeah, that was an ugly one. I rebased the branch on the current main; it passes I have yet to remember to sign a commit :-/ |
@spezifisch how does this new patch look? |
Initially mentioned this in the Album-blanking thread. Putting it here for clarity. Toggling the genre-mode mid-search results in some odd behavior. Video demonstrating this below. Only control inputs are "enter" -> "g" on the first search and on "Soundtrack" on the second. search-genre-bug.webmFor reference, there is a way to simulate latency on a local connection by adding a delay to an interface with |
This is forked off issue-76-clarify-search-results!!!
It's branched here because, otherwise, the merge for both will be nasty. It's a separate branch, because it adds a feature.
This implements #52.
search3
search/getGenres
a
I try to keep commits focused, but this commit changes a couple of other (unrelated) things:
You should be able to merge "clarify" and then merge this branch; or if you decide to merge both, just merge this branch and you'll get both.