Exhaustive check fixes #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
jsign
commented
Sep 11, 2024
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
jsign
force-pushed
the
jsign/exhaustive-fixes
branch
from
6d5eafe to
dc21bd6
Compare
Signed-off-by: Ignacio Hagopian <[email protected]>
jsign
force-pushed
the
jsign/exhaustive-fixes
branch
from
dc21bd6 to
5089d6a
Compare
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
jsign
commented
Sep 11, 2024
| @@ -157,15 +155,18 @@ def _extcodehash( | |||
|
|
|||
| post = {} | |||
| if not fails: | |||
| # TODO(verkle): assign correct storage slot value when filling | |||
| post[TestAddress2] = Account(code=pre[TestAddress2].code, storage={0: 0x424242}) | |||
There was a problem hiding this comment.
Looks like post-state checks maybe aren't working?
This 0x424242 is a fake value. Actually should be the EXTCODEHASH result saved in storage slot 0 (see L142 above).
So clearly this post-state check should fail. Moreover, you can change to any other value and still pass.
To run: fill --fork Verkle -v -m blockchain_test -n auto --evm-bin=... -k test_extcodehash_foo
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
jsign
force-pushed
the
jsign/exhaustive-fixes
branch
from
1169b28 to
0fcff0d
Compare
jsign
merged commit cfa073f
into
spencer-tb:verkle/block-witness-checks
0 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.