Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade vale #31

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix: upgrade vale #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ concurrency:
cancel-in-progress: true

env:
VALE_VERSION: "3.8.0"
VALE_VERSION: "3.9.1"

jobs:
run-ci:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/vale.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
inputs:
version:
description: "The version of the Vale to use"
default: "3.8.0"
default: "3.9.1"
type: string
required: false

Expand Down
13 changes: 12 additions & 1 deletion scripts/check_rule.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,19 @@

set -e


failed_tests=0

check_vale_installation() {
if command -v vale &> /dev/null
then
echo "✅ Vale is installed."
else
echo "❌ Vale is not installed."
echo "ℹ️ Use 'brew install vale' to install it with Homebrew."
exit 1
fi
}

# Function to get the last directory name from a given path. This is used to get the rule name.
get_last_directory_name() {
dir_path=$1
Expand Down Expand Up @@ -106,6 +116,7 @@ check_fail_conditions() {
# This function traverses the base directory and checks the pass and fail conditions for the Vale rules.
traverse_and_check() {
base_directory=$1
check_vale_installation

# Traverse the packages directory and look one level down
for package_dir in "$base_directory"/*; do
Expand Down
Loading