Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add new numbers rule DOC-1107 #25

Merged
merged 4 commits into from
Oct 18, 2024
Merged

docs: add new numbers rule DOC-1107 #25

merged 4 commits into from
Oct 18, 2024

Conversation

addetz
Copy link
Contributor

@addetz addetz commented Oct 16, 2024

Describe the Change

This PR adds a new rule that enforces all numbers zero through nine be spelled out. This rule is added in the spectrocloud scope.

Jira Tickets

🎫 DOC-1107

@addetz addetz requested a review from a team as a code owner October 16, 2024 13:15
Copy link
Contributor

@lennessyy lennessyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing i can think of is when we do release dates. But I think that we should be able to ignore vale in those cases - not sure if the effort to include those in the rule will be worth it

@addetz
Copy link
Contributor Author

addetz commented Oct 18, 2024

The only thing i can think of is when we do release dates. But I think that we should be able to ignore vale in those cases - not sure if the effort to include those in the rule will be worth it

Really great point! I have added a date exception to the rule now. Thanks for the great suggestion @lennessyy! 🙌

@addetz addetz merged commit e9c60ff into main Oct 18, 2024
3 checks passed
@addetz addetz deleted the spell-numbers-doc-1107 branch October 18, 2024 16:21
@vault-token-factory-spectrocloud

🎉 This PR is included in version 0.0.14 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants