PLT-1259: SDK Cut over with 4.3 changes #114
Conversation
| @@ -202,6 +207,11 @@ func (h *V1Client) baseTransport() *transport.Runtime { | |||
| return httpTransport | |||
| } | |||
|
|
|||
| func (h *V1Client) SetProjectContextForResource() *V1Client { | |||
There was a problem hiding this comment.
This can be accomplished by calling WithScopeProject. Please remove.
There was a problem hiding this comment.
This is required because in Terraform, we have the provision to set resource-level context.
During provider initialization, we use project scope or tenant scope based on the user settings during initialization. Later on, the user can also set the context at the resource level (if user have right access).
For example, a user can initialize the client with project scope and then switch to create a resource at the tenant level as well.
There was a problem hiding this comment.
I understand that, but there's already a way that you can handle the requirement without introducing a new method on the V1Client.
There was a problem hiding this comment.
Please ping me and we can discuss.
| @@ -234,3 +244,10 @@ func (h *V1Client) ValidateTenantAdmin() error { | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| func ContextWithProject(c context.Context, projectUid string) context.Context { | |||
There was a problem hiding this comment.
See above comment. This function should not be required.
There was a problem hiding this comment.
This is required because in Terraform, we have the provision to set resource-level context.
During provider initialization, we use project scope or tenant scope based on the user settings during initialization. Later on, the user can also set the context at the resource level (if user have right access).
For example, a user can initialize the client with project scope and then switch to create a resource at the tenant level as well.
There was a problem hiding this comment.
Same as above. Let's discuss.
No description provided.