Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added func for PQA-1848 #109

Merged
merged 4 commits into from
Jun 3, 2024
Merged

added func for PQA-1848 #109

merged 4 commits into from
Jun 3, 2024

Conversation

MGamya
Copy link
Contributor

@MGamya MGamya commented May 31, 2024

post and get API for log fetcher

@MGamya MGamya requested review from SivaanandM and TylerGillson and removed request for SivaanandM May 31, 2024 10:32
Copy link
Collaborator

@TylerGillson TylerGillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks aren't passing. Please resolve the failing GHAs and review comments.

client/cluster.go Outdated Show resolved Hide resolved
client/cluster.go Outdated Show resolved Hide resolved
client/cluster.go Outdated Show resolved Hide resolved
client/cluster.go Outdated Show resolved Hide resolved
client/cluster.go Outdated Show resolved Hide resolved
client/cluster.go Outdated Show resolved Hide resolved
@MGamya MGamya requested a review from TylerGillson June 1, 2024 06:52
Copy link
Collaborator

@TylerGillson TylerGillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing a couple var,err with no space - meaning go fmt wasn't run.

client/cluster.go Outdated Show resolved Hide resolved
@MGamya MGamya requested a review from TylerGillson June 2, 2024 15:36
@TylerGillson TylerGillson merged commit 92d0dd2 into main Jun 3, 2024
5 checks passed
@TylerGillson TylerGillson deleted the PQA-1848 branch June 3, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants