Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove package.json prepare #4388

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Conversation

karl-cardenas-coding
Copy link
Contributor

Describe the Change

This PR removes a setting that needs more experimentation from Netlify. Two packages were also moved up to dependencies vs devDependencies. axios and p-ratelimit is needed for the packs download. If the env variable NODE_ENV is set to production then Netlify will not install dev dependencies. That will cause issues for our pre-build steps that retrieve packs, and security bulletins [future].

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner October 19, 2024 16:11
@karl-cardenas-coding karl-cardenas-coding added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 backport-version-4-5 Backport changes to the version-4-5 branch. dependencies Pull requests that update a dependency file labels Oct 19, 2024
Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit efec71e
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/6713da2cb794ca00088697a2
😎 Deploy Preview https://deploy-preview-4388--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@karl-cardenas-coding karl-cardenas-coding merged commit 8bfcdb7 into master Oct 19, 2024
36 of 37 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the netlify-package-json branch October 19, 2024 16:32
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Oct 19, 2024
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Oct 19, 2024
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Oct 19, 2024
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Oct 19, 2024
@vault-token-factory-spectrocloud
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
version-4-0 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-0:
- chore: released docs versioning
version-3-4 Backport failed because of merge conflicts

You might need to backport the following PRs to version-3-4:
- chore: released docs versioning
version-4-1 Backport failed because of merge conflicts
version-4-2
version-4-3
version-4-4
version-4-5

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 4388

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Oct 19, 2024
(cherry picked from commit 8bfcdb7)

Co-authored-by: Karl Cardenas <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Oct 19, 2024
(cherry picked from commit 8bfcdb7)

Co-authored-by: Karl Cardenas <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Oct 19, 2024
(cherry picked from commit 8bfcdb7)

Co-authored-by: Karl Cardenas <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Oct 19, 2024
(cherry picked from commit 8bfcdb7)

Co-authored-by: Karl Cardenas <[email protected]>
@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This issue has been resolved in version 4.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 backport-version-4-5 Backport changes to the version-4-5 branch. dependencies Pull requests that update a dependency file released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant