Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: PLT-1405 #4066

Merged
merged 7 commits into from
Sep 30, 2024
Merged

docs: PLT-1405 #4066

merged 7 commits into from
Sep 30, 2024

Conversation

karl-cardenas-coding
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding commented Sep 24, 2024

Describe the Change

This PR documents a limitation with VM migration related to the Multus CNI.

CleanShot 2024-09-24 at 15 59 28

Changed Pages

💻 Preview URL for Page

Jira Tickets

🎫 PLT-1405

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

@karl-cardenas-coding karl-cardenas-coding added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 labels Sep 24, 2024
@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner September 24, 2024 22:59
Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 2b0aa0b
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/66f6d62ef62385000857f804
😎 Deploy Preview https://deploy-preview-4066--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -22,6 +22,9 @@ from VMware vSphere to Palette VMO.
- Only VMs whose operating systems are included under
[`virt-v2v` supported guest systems](https://libguestfs.org/virt-v2v-support.1.html) can be migrated.

- When using <VersionedLink text="Multus CNI" url="/integrations/packs/?pack=cni-multus" />, the Network Attachment
Definition (NAD) used must match the same name assigned to the migration. Otherwise, the migration will fail.
Copy link
Contributor

@TylerGillson TylerGillson Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karl-cardenas-coding the CLI doesn't prompt the user for a NAD yet, so this is kinda unclear. They just pick Pod or Multus and there's no mention of NADs.

A NAD must exist in the migration's target namespace and its name must match the migration name.

@TylerGillson TylerGillson self-requested a review September 25, 2024 13:30
Copy link
Contributor

@caroldelwing caroldelwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@karl-cardenas-coding karl-cardenas-coding merged commit ddded8e into master Sep 30, 2024
15 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the vmo-fix branch September 30, 2024 14:38
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Sep 30, 2024
* docs: PLT-1405

* docs: removed prettier comment

* chore: vale feedback

* docs: feedback from Tyler

* docs: apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

---------

Co-authored-by: caroldelwing <[email protected]>
(cherry picked from commit ddded8e)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Sep 30, 2024
* docs: PLT-1405

* docs: removed prettier comment

* chore: vale feedback

* docs: feedback from Tyler

* docs: apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

---------

Co-authored-by: caroldelwing <[email protected]>
(cherry picked from commit ddded8e)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Sep 30, 2024
* docs: PLT-1405

* docs: removed prettier comment

* chore: vale feedback

* docs: feedback from Tyler

* docs: apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

---------

Co-authored-by: caroldelwing <[email protected]>
(cherry picked from commit ddded8e)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Sep 30, 2024
* docs: PLT-1405

* docs: removed prettier comment

* chore: vale feedback

* docs: feedback from Tyler

* docs: apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

---------

Co-authored-by: caroldelwing <[email protected]>
(cherry picked from commit ddded8e)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Sep 30, 2024
* docs: PLT-1405

* docs: removed prettier comment

* chore: vale feedback

* docs: feedback from Tyler

* docs: apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

---------

Co-authored-by: caroldelwing <[email protected]>
(cherry picked from commit ddded8e)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-0
version-4-1
version-4-2
version-4-3
version-4-4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Sep 30, 2024
* docs: PLT-1405

* docs: removed prettier comment

* chore: vale feedback

* docs: feedback from Tyler

* docs: apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

---------

Co-authored-by: caroldelwing <[email protected]>
(cherry picked from commit ddded8e)

Co-authored-by: Karl Cardenas <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Sep 30, 2024
* docs: PLT-1405

* docs: removed prettier comment

* chore: vale feedback

* docs: feedback from Tyler

* docs: apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

---------

Co-authored-by: caroldelwing <[email protected]>
(cherry picked from commit ddded8e)

Co-authored-by: Karl Cardenas <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Sep 30, 2024
* docs: PLT-1405

* docs: removed prettier comment

* chore: vale feedback

* docs: feedback from Tyler

* docs: apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

---------

Co-authored-by: caroldelwing <[email protected]>
(cherry picked from commit ddded8e)

Co-authored-by: Karl Cardenas <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Sep 30, 2024
* docs: PLT-1405

* docs: removed prettier comment

* chore: vale feedback

* docs: feedback from Tyler

* docs: apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

---------

Co-authored-by: caroldelwing <[email protected]>
(cherry picked from commit ddded8e)

Co-authored-by: Karl Cardenas <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Sep 30, 2024
* docs: PLT-1405

* docs: removed prettier comment

* chore: vale feedback

* docs: feedback from Tyler

* docs: apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

---------

Co-authored-by: caroldelwing <[email protected]>
(cherry picked from commit ddded8e)

Co-authored-by: Karl Cardenas <[email protected]>
@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This issue has been resolved in version 4.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants