Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: PLT-1397 clarify CDI upload proxy wording for ova import #4053

Merged
merged 7 commits into from
Sep 24, 2024

Conversation

arturshadnik
Copy link
Contributor

@arturshadnik arturshadnik commented Sep 23, 2024

Describe the Change

This PR updates the wording for the CDI Upload proxy section in the VMO - OVA import section to better explain how to set up an import when a proxy is used.

Changed Pages

💻 Preview URL for Page

Jira Tickets

🎫 Jira Ticket

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

@arturshadnik arturshadnik added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 labels Sep 23, 2024
@arturshadnik arturshadnik requested a review from a team as a code owner September 23, 2024 23:47
Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/66f343ac92d45167a052d868
😎 Deploy Preview https://deploy-preview-4053--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @arturshadnik 🚀

@karl-cardenas-coding karl-cardenas-coding merged commit 8960236 into master Sep 24, 2024
10 of 15 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the PLT-1397 branch September 24, 2024 23:29
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Sep 24, 2024
* docs: PLT-1397 clarify CDI upload proxy wording for ova import

Signed-off-by: Artur Shad Nik <[email protected]>

* ci: auto-formatting prettier issues

* Update deploy-import-ova.md

* ci: auto-formatting prettier issues

* docs: defined CDI

* docs: suggestion fix

---------

Signed-off-by: Artur Shad Nik <[email protected]>
Co-authored-by: arturshadnik <[email protected]>
Co-authored-by: Tyler Gillson <[email protected]>
Co-authored-by: TylerGillson <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit 8960236)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Sep 24, 2024
* docs: PLT-1397 clarify CDI upload proxy wording for ova import

Signed-off-by: Artur Shad Nik <[email protected]>

* ci: auto-formatting prettier issues

* Update deploy-import-ova.md

* ci: auto-formatting prettier issues

* docs: defined CDI

* docs: suggestion fix

---------

Signed-off-by: Artur Shad Nik <[email protected]>
Co-authored-by: arturshadnik <[email protected]>
Co-authored-by: Tyler Gillson <[email protected]>
Co-authored-by: TylerGillson <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit 8960236)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Sep 24, 2024
* docs: PLT-1397 clarify CDI upload proxy wording for ova import

Signed-off-by: Artur Shad Nik <[email protected]>

* ci: auto-formatting prettier issues

* Update deploy-import-ova.md

* ci: auto-formatting prettier issues

* docs: defined CDI

* docs: suggestion fix

---------

Signed-off-by: Artur Shad Nik <[email protected]>
Co-authored-by: arturshadnik <[email protected]>
Co-authored-by: Tyler Gillson <[email protected]>
Co-authored-by: TylerGillson <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit 8960236)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Sep 24, 2024
* docs: PLT-1397 clarify CDI upload proxy wording for ova import

Signed-off-by: Artur Shad Nik <[email protected]>

* ci: auto-formatting prettier issues

* Update deploy-import-ova.md

* ci: auto-formatting prettier issues

* docs: defined CDI

* docs: suggestion fix

---------

Signed-off-by: Artur Shad Nik <[email protected]>
Co-authored-by: arturshadnik <[email protected]>
Co-authored-by: Tyler Gillson <[email protected]>
Co-authored-by: TylerGillson <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit 8960236)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Sep 24, 2024
* docs: PLT-1397 clarify CDI upload proxy wording for ova import

Signed-off-by: Artur Shad Nik <[email protected]>

* ci: auto-formatting prettier issues

* Update deploy-import-ova.md

* ci: auto-formatting prettier issues

* docs: defined CDI

* docs: suggestion fix

---------

Signed-off-by: Artur Shad Nik <[email protected]>
Co-authored-by: arturshadnik <[email protected]>
Co-authored-by: Tyler Gillson <[email protected]>
Co-authored-by: TylerGillson <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit 8960236)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-0
version-4-1
version-4-2
version-4-3
version-4-4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Sep 24, 2024
#4067)

* docs: PLT-1397 clarify CDI upload proxy wording for ova import

Signed-off-by: Artur Shad Nik <[email protected]>

* ci: auto-formatting prettier issues

* Update deploy-import-ova.md

* ci: auto-formatting prettier issues

* docs: defined CDI

* docs: suggestion fix

---------

Signed-off-by: Artur Shad Nik <[email protected]>
Co-authored-by: arturshadnik <[email protected]>
Co-authored-by: Tyler Gillson <[email protected]>
Co-authored-by: TylerGillson <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit 8960236)

Co-authored-by: Artur Shad Nik <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Sep 24, 2024
#4068)

* docs: PLT-1397 clarify CDI upload proxy wording for ova import

Signed-off-by: Artur Shad Nik <[email protected]>

* ci: auto-formatting prettier issues

* Update deploy-import-ova.md

* ci: auto-formatting prettier issues

* docs: defined CDI

* docs: suggestion fix

---------

Signed-off-by: Artur Shad Nik <[email protected]>
Co-authored-by: arturshadnik <[email protected]>
Co-authored-by: Tyler Gillson <[email protected]>
Co-authored-by: TylerGillson <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit 8960236)

Co-authored-by: Artur Shad Nik <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Sep 24, 2024
#4070)

* docs: PLT-1397 clarify CDI upload proxy wording for ova import

Signed-off-by: Artur Shad Nik <[email protected]>

* ci: auto-formatting prettier issues

* Update deploy-import-ova.md

* ci: auto-formatting prettier issues

* docs: defined CDI

* docs: suggestion fix

---------

Signed-off-by: Artur Shad Nik <[email protected]>
Co-authored-by: arturshadnik <[email protected]>
Co-authored-by: Tyler Gillson <[email protected]>
Co-authored-by: TylerGillson <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit 8960236)

Co-authored-by: Artur Shad Nik <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Sep 24, 2024
#4071)

* docs: PLT-1397 clarify CDI upload proxy wording for ova import

Signed-off-by: Artur Shad Nik <[email protected]>

* ci: auto-formatting prettier issues

* Update deploy-import-ova.md

* ci: auto-formatting prettier issues

* docs: defined CDI

* docs: suggestion fix

---------

Signed-off-by: Artur Shad Nik <[email protected]>
Co-authored-by: arturshadnik <[email protected]>
Co-authored-by: Tyler Gillson <[email protected]>
Co-authored-by: TylerGillson <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit 8960236)

Co-authored-by: Artur Shad Nik <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Sep 25, 2024
#4069)

* docs: PLT-1397 clarify CDI upload proxy wording for ova import

Signed-off-by: Artur Shad Nik <[email protected]>

* ci: auto-formatting prettier issues

* Update deploy-import-ova.md

* ci: auto-formatting prettier issues

* docs: defined CDI

* docs: suggestion fix

---------

Signed-off-by: Artur Shad Nik <[email protected]>
Co-authored-by: arturshadnik <[email protected]>
Co-authored-by: Tyler Gillson <[email protected]>
Co-authored-by: TylerGillson <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit 8960236)

Co-authored-by: Artur Shad Nik <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This issue has been resolved in version 4.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants