Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC Transcoding #4051

Merged
merged 9 commits into from
Sep 24, 2024
Merged

gRPC Transcoding #4051

merged 9 commits into from
Sep 24, 2024

Conversation

karl-cardenas-coding
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding commented Sep 23, 2024

Describe the Change

This PR documents the gRPC over WebSocket solution.

Changed Pages

💻 Preview URL for Page

Jira Tickets

🎫 PEM-5725

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

frederickjoi and others added 2 commits September 23, 2024 11:30
* 9-23-24 cve updates

* ci: auto-formatting prettier issues

---------

Co-authored-by: frederickjoi <[email protected]>
@karl-cardenas-coding karl-cardenas-coding added auto-backport Enable backport backport-version-4-4 Backport change to version 4.4 labels Sep 23, 2024
Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 19b01d2
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/66f2f3c9dd0ed80008b1359b
😎 Deploy Preview https://deploy-preview-4051--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@karl-cardenas-coding karl-cardenas-coding changed the title docs: PEM-5725 gRPC Transcoding Sep 23, 2024
@karl-cardenas-coding karl-cardenas-coding marked this pull request as ready for review September 23, 2024 22:54
@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner September 23, 2024 22:54
docs/docs-content/architecture/grps-proxy.md Show resolved Hide resolved
docs/docs-content/architecture/grps-proxy.md Show resolved Hide resolved
docs/docs-content/architecture/grps-proxy.md Show resolved Hide resolved
docs/docs-content/architecture/grps-proxy.md Show resolved Hide resolved
docs/docs-content/architecture/grps-proxy.md Outdated Show resolved Hide resolved
docs/docs-content/architecture/grps-proxy.md Show resolved Hide resolved
docs/docs-content/architecture/grps-proxy.md Show resolved Hide resolved
docs/docs-content/architecture/grps-proxy.md Show resolved Hide resolved
docs/docs-content/architecture/grps-proxy.md Show resolved Hide resolved
docs/docs-content/architecture/grps-proxy.md Outdated Show resolved Hide resolved
@guyni guyni self-requested a review September 23, 2024 23:14
Copy link

@guyni guyni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@caroldelwing caroldelwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very detailed! I left one tiny question :)

docs/docs-content/architecture/grps-proxy.md Outdated Show resolved Hide resolved
docs/docs-content/architecture/grps-proxy.md Outdated Show resolved Hide resolved
docs/docs-content/architecture/grps-proxy.md Outdated Show resolved Hide resolved
docs/docs-content/architecture/grps-proxy.md Outdated Show resolved Hide resolved
docs/docs-content/architecture/grps-proxy.md Outdated Show resolved Hide resolved
docs/docs-content/architecture/grps-proxy.md Outdated Show resolved Hide resolved
docs/docs-content/architecture/grps-proxy.md Outdated Show resolved Hide resolved
@karl-cardenas-coding karl-cardenas-coding changed the base branch from master to 4-4-20-notes September 24, 2024 17:27
@karl-cardenas-coding karl-cardenas-coding merged commit a74f3ac into 4-4-20-notes Sep 24, 2024
17 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the grpc-websockets branch September 24, 2024 17:27
@karl-cardenas-coding karl-cardenas-coding removed auto-backport Enable backport backport-version-4-4 Backport change to version 4.4 labels Sep 24, 2024
caroldelwing added a commit that referenced this pull request Sep 25, 2024
* docs: DOC-1385

* docs: Apply suggestions from code review

* ci: auto-formatting prettier issues

* docs: Apply suggestions from code review

Co-authored-by: Lenny Chen <[email protected]>

* docs: PEM-5725 gRPC Transcoding (#4051)

* docs: 9-23-24 cve updates (#4046)

* 9-23-24 cve updates

* ci: auto-formatting prettier issues

---------

Co-authored-by: frederickjoi <[email protected]>

* docs: PEM-5725

* docs: review feedback

* docs: vale feedback

* docs: apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

* ci: auto-formatting prettier issues

* docs: feedback updates

---------

Co-authored-by: frederickjoi <[email protected]>
Co-authored-by: frederickjoi <[email protected]>
Co-authored-by: caroldelwing <[email protected]>
Co-authored-by: karl-cardenas-coding <[email protected]>

* docs: updated release notes with gRPC link

* docs: fix indentation issue

---------

Co-authored-by: karl-cardenas-coding <[email protected]>
Co-authored-by: Lenny Chen <[email protected]>
Co-authored-by: frederickjoi <[email protected]>
Co-authored-by: frederickjoi <[email protected]>
Co-authored-by: caroldelwing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants