-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gRPC Transcoding #4051
Merged
Merged
gRPC Transcoding #4051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 9-23-24 cve updates * ci: auto-formatting prettier issues --------- Co-authored-by: frederickjoi <[email protected]>
karl-cardenas-coding
added
auto-backport
Enable backport
backport-version-4-4
Backport change to version 4.4
labels
Sep 23, 2024
✅ Deploy Preview for docs-spectrocloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
guyni
reviewed
Sep 23, 2024
karl-cardenas-coding
requested review from
addetz,
lennessyy and
caroldelwing
September 23, 2024 22:54
guyni
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
caroldelwing
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very detailed! I left one tiny question :)
Co-authored-by: caroldelwing <[email protected]>
karl-cardenas-coding
removed
auto-backport
Enable backport
backport-version-4-4
Backport change to version 4.4
labels
Sep 24, 2024
caroldelwing
added a commit
that referenced
this pull request
Sep 25, 2024
* docs: DOC-1385 * docs: Apply suggestions from code review * ci: auto-formatting prettier issues * docs: Apply suggestions from code review Co-authored-by: Lenny Chen <[email protected]> * docs: PEM-5725 gRPC Transcoding (#4051) * docs: 9-23-24 cve updates (#4046) * 9-23-24 cve updates * ci: auto-formatting prettier issues --------- Co-authored-by: frederickjoi <[email protected]> * docs: PEM-5725 * docs: review feedback * docs: vale feedback * docs: apply suggestions from code review Co-authored-by: caroldelwing <[email protected]> * ci: auto-formatting prettier issues * docs: feedback updates --------- Co-authored-by: frederickjoi <[email protected]> Co-authored-by: frederickjoi <[email protected]> Co-authored-by: caroldelwing <[email protected]> Co-authored-by: karl-cardenas-coding <[email protected]> * docs: updated release notes with gRPC link * docs: fix indentation issue --------- Co-authored-by: karl-cardenas-coding <[email protected]> Co-authored-by: Lenny Chen <[email protected]> Co-authored-by: frederickjoi <[email protected]> Co-authored-by: frederickjoi <[email protected]> Co-authored-by: caroldelwing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Change
This PR documents the gRPC over WebSocket solution.
Changed Pages
💻 Preview URL for Page
Jira Tickets
🎫 PEM-5725
Backports
Can this PR be backported?