Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: DOC-1362 #3929

Merged
merged 10 commits into from
Sep 17, 2024
Merged

docs: DOC-1362 #3929

merged 10 commits into from
Sep 17, 2024

Conversation

karl-cardenas-coding
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding commented Sep 16, 2024

Describe the Change

This PR adds steps to delete an API key programmatically. Additional guidance in the API Key index page has also been added.

Changed Pages

💻 API Key Index Page Updates

💻 Delete API Key

Jira Tickets

🎫 DOC-1362

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 71d05d7
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/66e9f1bc8eb91f0008a9432b
😎 Deploy Preview https://deploy-preview-3929--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@karl-cardenas-coding karl-cardenas-coding added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 labels Sep 16, 2024
@karl-cardenas-coding karl-cardenas-coding marked this pull request as ready for review September 16, 2024 16:15
@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner September 16, 2024 16:15
Copy link
Contributor

@caroldelwing caroldelwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great guide! Just tiny suggestions :)

Copy link
Contributor

@addetz addetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just couple of suggestions :)


## Limitations

- API keys that belong to Palette users removed from the organization through OIDC/SAML are not automatically removed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps provide a reference to where users can find all issued API keys?

## Limitations

Palette API keys that belong to Palette users removed from the organization through OIDC/SAML are not automatically
removed. We recommend that you remove these keys to ensure that they are no longer used. You can programmatically remove
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Vale.Terms] Use 'we' instead of 'We'.

## Limitations

Palette [API keys](../authentication/api-key/api-key.md) that belong to Palette users removed from the organization
through OIDC/SAML are not automatically removed. We recommend that you remove these keys to ensure that they are no
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Vale.Terms] Use 'we' instead of 'We'.

@karl-cardenas-coding karl-cardenas-coding merged commit 8c9cbab into master Sep 17, 2024
15 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the API_keys branch September 17, 2024 21:35
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Sep 17, 2024
* docs: DOC-1362

* docs: more updates

* docs: vale fix

* docs: feedback apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

* ci: auto-formatting prettier issues

* docs: feedback

* docs: feedback changes

---------

Co-authored-by: caroldelwing <[email protected]>
Co-authored-by: karl-cardenas-coding <[email protected]>
(cherry picked from commit 8c9cbab)
@vault-token-factory-spectrocloud
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
version-4-0 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-0:
- docs: add new vsphere known issue (#3896)
- docs: confirm cert renewal by looking at expiry date (#3886)
- docs: DOC-1372 (#3840)
version-4-1 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-1:
- docs: add new vsphere known issue (#3896)
- docs: confirm cert renewal by looking at expiry date (#3886)
- docs: DOC-1372 (#3840)
- chore: bump @argos-ci/cli from 2.3.1 to 2.4.2 (#3798)
version-4-2 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-2:
- docs: add new vsphere known issue (#3896)
- docs: confirm cert renewal by looking at expiry date (#3886)
- docs: PE-4831 (#3809)
version-4-3 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-3:
- docs: confirm cert renewal by looking at expiry date (#3886)
- docs: PE-4831 (#3809)
version-4-4

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 3929

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Sep 17, 2024
* docs: DOC-1362

* docs: more updates

* docs: vale fix

* docs: feedback apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

* ci: auto-formatting prettier issues

* docs: feedback

* docs: feedback changes

---------

Co-authored-by: caroldelwing <[email protected]>
Co-authored-by: karl-cardenas-coding <[email protected]>
(cherry picked from commit 8c9cbab)

Co-authored-by: Karl Cardenas <[email protected]>
karl-cardenas-coding added a commit that referenced this pull request Sep 17, 2024
* docs: DOC-1362

* docs: more updates

* docs: vale fix

* docs: feedback apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

* ci: auto-formatting prettier issues

* docs: feedback

* docs: feedback changes

---------

Co-authored-by: caroldelwing <[email protected]>
Co-authored-by: karl-cardenas-coding <[email protected]>
karl-cardenas-coding added a commit that referenced this pull request Sep 17, 2024
* docs: DOC-1362

* docs: more updates

* docs: vale fix

* docs: feedback apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

* ci: auto-formatting prettier issues

* docs: feedback

* docs: feedback changes

---------

Co-authored-by: caroldelwing <[email protected]>
Co-authored-by: karl-cardenas-coding <[email protected]>
karl-cardenas-coding added a commit that referenced this pull request Sep 17, 2024
* docs: DOC-1362

* docs: more updates

* docs: vale fix

* docs: feedback apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

* ci: auto-formatting prettier issues

* docs: feedback

* docs: feedback changes

---------

Co-authored-by: caroldelwing <[email protected]>
Co-authored-by: karl-cardenas-coding <[email protected]>
karl-cardenas-coding added a commit that referenced this pull request Sep 17, 2024
* docs: DOC-1362

* docs: more updates

* docs: vale fix

* docs: feedback apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

* ci: auto-formatting prettier issues

* docs: feedback

* docs: feedback changes

---------

Co-authored-by: caroldelwing <[email protected]>
Co-authored-by: karl-cardenas-coding <[email protected]>
karl-cardenas-coding added a commit that referenced this pull request Sep 17, 2024
* docs: DOC-1362

* docs: more updates

* docs: vale fix

* docs: feedback apply suggestions from code review



* ci: auto-formatting prettier issues

* docs: feedback

* docs: feedback changes

---------

Co-authored-by: caroldelwing <[email protected]>
Co-authored-by: karl-cardenas-coding <[email protected]>
karl-cardenas-coding added a commit that referenced this pull request Sep 17, 2024
* docs: DOC-1362

* docs: more updates

* docs: vale fix

* docs: feedback apply suggestions from code review



* ci: auto-formatting prettier issues

* docs: feedback

* docs: feedback changes

---------

Co-authored-by: caroldelwing <[email protected]>
Co-authored-by: karl-cardenas-coding <[email protected]>
karl-cardenas-coding added a commit that referenced this pull request Sep 17, 2024
* docs: DOC-1362

* docs: more updates

* docs: vale fix

* docs: feedback apply suggestions from code review



* ci: auto-formatting prettier issues

* docs: feedback

* docs: feedback changes

---------

Co-authored-by: caroldelwing <[email protected]>
Co-authored-by: karl-cardenas-coding <[email protected]>
karl-cardenas-coding added a commit that referenced this pull request Sep 17, 2024
* docs: DOC-1362

* docs: more updates

* docs: vale fix

* docs: feedback apply suggestions from code review



* ci: auto-formatting prettier issues

* docs: feedback

* docs: feedback changes

---------

Co-authored-by: caroldelwing <[email protected]>
Co-authored-by: karl-cardenas-coding <[email protected]>
@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This issue has been resolved in version 4.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants