Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: profile basic information regarding external registry using pro… #3661

Merged
merged 16 commits into from
Sep 3, 2024

Conversation

lennessyy
Copy link
Contributor

@lennessyy lennessyy commented Aug 20, 2024

Describe the Change

This PR adds the ability to configure external registries using cluster profiles instead of user data.

Changed Pages

💻 Preview URL for Page

Jira Tickets

🎫 DOC-1340

Backports

Can this PR be backported?

  • Yes.

@lennessyy lennessyy marked this pull request as ready for review August 20, 2024 18:19
@lennessyy lennessyy requested a review from a team as a code owner August 20, 2024 18:19
@lennessyy lennessyy marked this pull request as draft August 20, 2024 18:20
Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit d963dbb
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/66d77e080f95e6000838daeb
😎 Deploy Preview https://deploy-preview-3661--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lennessyy lennessyy marked this pull request as ready for review August 27, 2024 20:59
@lennessyy lennessyy requested a review from rishi-anand August 27, 2024 21:00
@lennessyy lennessyy added auto-backport Enable backport backport-version-4-4 Backport change to version 4.4 labels Aug 27, 2024
@rishi-anand
Copy link
Contributor

@kirankn8 Please review.. Do we need data.name in secret?

Copy link
Contributor

@rishi-anand rishi-anand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @lennessyy 👍

Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very detailed and helpful guide @lennessyy

@lennessyy lennessyy enabled auto-merge (squash) September 3, 2024 21:22
@lennessyy lennessyy merged commit 58f5b6e into master Sep 3, 2024
14 of 15 checks passed
@lennessyy lennessyy deleted the profile-external-registry branch September 3, 2024 21:36
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Sep 3, 2024
#3661)

* docs: profile basic information regarding external registry using profiles

* docs: add instructions for private registries

* docs: fix syntax issue

* docs: add info on how to provide secrets

* docs: clarify parameters

* docs: adjust heading levels

* docs: fix syntax issue

* Update docs/docs-content/clusters/edge/site-deployment/deploy-custom-registries/local-registry.md

Co-authored-by: Karl Cardenas <[email protected]>

* ci: auto-formatting prettier issues

---------

Co-authored-by: Lenny Chen <[email protected]>
Co-authored-by: Rishi Anand <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
Co-authored-by: lennessyy <[email protected]>
(cherry picked from commit 58f5b6e)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

lennessyy added a commit that referenced this pull request Sep 4, 2024
#3661) (#3788)

* docs: profile basic information regarding external registry using profiles

* docs: add instructions for private registries

* docs: fix syntax issue

* docs: add info on how to provide secrets

* docs: clarify parameters

* docs: adjust heading levels

* docs: fix syntax issue

* Update docs/docs-content/clusters/edge/site-deployment/deploy-custom-registries/local-registry.md

Co-authored-by: Karl Cardenas <[email protected]>

* ci: auto-formatting prettier issues

---------

Co-authored-by: Lenny Chen <[email protected]>
Co-authored-by: Rishi Anand <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
Co-authored-by: lennessyy <[email protected]>
(cherry picked from commit 58f5b6e)

Co-authored-by: Lenny Chen <[email protected]>
Co-authored-by: Karl Cardenas <[email protected]>
@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This issue has been resolved in version 4.4.13 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-4-4 Backport change to version 4.4 released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants