Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update colon.yml #3084

Merged
merged 1 commit into from
Jun 13, 2024
Merged

docs: Update colon.yml #3084

merged 1 commit into from
Jun 13, 2024

Conversation

karl-cardenas-coding
Copy link
Contributor

Describe the Change

This PR updates the regex to the colon rule to reduce false positives. Admonitions kept getting caught and other valid use cases. The new regex handles the valid use cases.

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

@karl-cardenas-coding karl-cardenas-coding added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 labels Jun 13, 2024
@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner June 13, 2024 18:38
Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 175f6c6
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/666b3cab47507c000877e3f3
😎 Deploy Preview https://deploy-preview-3084--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@karl-cardenas-coding karl-cardenas-coding merged commit 2b9f142 into master Jun 13, 2024
21 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the vale-update-colon branch June 13, 2024 18:58
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jun 13, 2024
(cherry picked from commit 2b9f142)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jun 13, 2024
(cherry picked from commit 2b9f142)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jun 13, 2024
(cherry picked from commit 2b9f142)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jun 13, 2024
(cherry picked from commit 2b9f142)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jun 13, 2024
(cherry picked from commit 2b9f142)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-0
version-3-4
version-4-1
version-4-2
version-4-3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jun 13, 2024
(cherry picked from commit 2b9f142)

Co-authored-by: Karl Cardenas <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jun 13, 2024
(cherry picked from commit 2b9f142)

Co-authored-by: Karl Cardenas <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jun 13, 2024
(cherry picked from commit 2b9f142)

Co-authored-by: Karl Cardenas <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jun 13, 2024
(cherry picked from commit 2b9f142)

Co-authored-by: Karl Cardenas <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jun 13, 2024
(cherry picked from commit 2b9f142)

Co-authored-by: Karl Cardenas <[email protected]>
@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This PR is included in version 4.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants