Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove PCG section in Azure #2422

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

karl-cardenas-coding
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding commented Mar 18, 2024

Describe the Change

This PR deprecates a PCG page that was located in the Azure section.

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

@karl-cardenas-coding karl-cardenas-coding added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 labels Mar 18, 2024
@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner March 18, 2024 17:57
Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 509356b
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/65f880b6b9cbc9000860ba55
😎 Deploy Preview https://deploy-preview-2422--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Clusters that use a Palette self-hosted [Private Cloud Gateway](gateways.md) (PCG), should use a custom storage account
and container that are restricted to the VNet that the PCG and cluster are located in. Ensure you disable public access
and use private access for the Azure storage account.
Clusters that use a Palette self-hosted [Private Cloud Gateway](../../pcg/architecture.md) (PCG), should use a custom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Vale.Terms] Use 'cloud' instead of 'Cloud'.

and use private access for the Azure storage account.
Clusters that use a Palette self-hosted [Private Cloud Gateway](../../pcg/architecture.md) (PCG), should use a custom
storage account and container that are restricted to the VNet that the PCG and cluster are located in. Ensure you
disable public access and use private access for the Azure storage account.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Vale.Terms] Use 'Disable' instead of 'disable'.

@@ -45,7 +45,7 @@ Use the following steps to add an Azure or Azure Government account in Palette o
| **Cloud** | Select **Azure Public Cloud** or **Azure US Government**. |
| **Tenant Name** | An optional tenant name. |
| **Disable Properties** | This option prevents Palette and VerteX from creating Azure Virtual Networks (VNets) and other network resources on your behalf for static placement deployments. If you enable this option, all users must manually specify a pre-existing VNet, subnets, and security groups when creating clusters. |
| **Connect Private Cloud Gateway** | If you will be launching Managed Kubernetes Service (AKS), use the **drop-down Menu** to select a [self-hosted PCG](gateways.md) that you created to link to the cloud account. |
| **Connect Private Cloud Gateway** | Select this option to connect to a Private Cloud Gateway (PCG) if you have a PCG deployed in your environment. Refer to the PCG [Architecture](../../pcg/architecture.md) page to learn more about a PCG. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Vale.Terms] Use 'cloud' instead of 'Cloud'.

Copy link
Contributor

@yuliiiah yuliiiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with claps 👏🏻

@karl-cardenas-coding karl-cardenas-coding merged commit 587d3d3 into master Mar 18, 2024
10 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the remove-azure-pcg branch March 18, 2024 19:38
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Mar 18, 2024
* chore: remove PCG section in Azure

* docs: pcg change

(cherry picked from commit 587d3d3)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Mar 18, 2024
* chore: remove PCG section in Azure

* docs: pcg change

(cherry picked from commit 587d3d3)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Mar 18, 2024
* chore: remove PCG section in Azure

* docs: pcg change

(cherry picked from commit 587d3d3)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-0
version-4-1
version-4-2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Mar 18, 2024
* chore: remove PCG section in Azure

* docs: pcg change

(cherry picked from commit 587d3d3)

Co-authored-by: Karl Cardenas <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Mar 18, 2024
* chore: remove PCG section in Azure

* docs: pcg change

(cherry picked from commit 587d3d3)

Co-authored-by: Karl Cardenas <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Mar 18, 2024
* chore: remove PCG section in Azure

* docs: pcg change

(cherry picked from commit 587d3d3)

Co-authored-by: Karl Cardenas <[email protected]>
@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This PR is included in version 4.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This PR is included in version 4.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants