Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move securty notices to a more visible spot #2380

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

karl-cardenas-coding
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding commented Mar 7, 2024

Describe the Change

This PR moves the security bulletin section to the main left navigation menu, bellow release notes.

Changed Pages

💻 Preview URL for Page

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

@karl-cardenas-coding karl-cardenas-coding added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 labels Mar 7, 2024
@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner March 7, 2024 21:13
Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 6c88051
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/65ea2e749210b100083a6000
😎 Deploy Preview https://deploy-preview-2380--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@lennessyy lennessyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I may have missed this discussion, but i kind of liked not having an icon for "What is Palette". It initially bothered me, but it worked as a nice divider between release notes and other content. Especially now that we are adding another section to before "What is Palette", it may not be a bad idea to keep it, especially if the goal is to draw attention to the security bulletin section?

@karl-cardenas-coding karl-cardenas-coding merged commit 1dee9d3 into master Mar 7, 2024
12 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the bulletis-move branch March 7, 2024 22:09
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Mar 7, 2024
* docs: move securty notices to a more visible spot

* chore: added redirects

(cherry picked from commit 1dee9d3)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Mar 7, 2024
* docs: move securty notices to a more visible spot

* chore: added redirects

(cherry picked from commit 1dee9d3)
@vault-token-factory-spectrocloud
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
version-4-0 Backport failed because of merge conflicts
version-3-4 Backport failed because of merge conflicts

You might need to backport the following PRs to version-3-4:
- Refactor/restructure cluster & app profiles sections (#1551)
version-4-1
version-4-2

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 2380

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Mar 7, 2024
* docs: move securty notices to a more visible spot

* chore: added redirects

(cherry picked from commit 1dee9d3)

Co-authored-by: Karl Cardenas <[email protected]>
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Mar 7, 2024
* docs: move securty notices to a more visible spot

* chore: added redirects

(cherry picked from commit 1dee9d3)

Co-authored-by: Karl Cardenas <[email protected]>
karl-cardenas-coding added a commit that referenced this pull request Mar 7, 2024
* docs: move securty notices to a more visible spot

* chore: added redirects
karl-cardenas-coding added a commit that referenced this pull request Mar 7, 2024
* docs: move securty notices to a more visible spot

* chore: added redirects
karl-cardenas-coding added a commit that referenced this pull request Mar 7, 2024
* docs: move securty notices to a more visible spot

* chore: added redirects
karl-cardenas-coding added a commit that referenced this pull request Mar 7, 2024
* docs: move securty notices to a more visible spot

* chore: added redirects
@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This PR is included in version 4.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This PR is included in version 4.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants