-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to docusarus v3 #1914
Conversation
✅ Deploy Preview for docs-spectrocloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -49,7 +49,7 @@ export default function CodeBlockString({ | |||
> | |||
{title && <div className={styles.codeBlockTitle}>{title}</div>} | |||
<div className={styles.codeBlockContent}> | |||
<Highlight {...defaultProps} theme={prismTheme} code={code} language={language ?? "text"}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I investigated this one. defaultProps
is not being exported anymore. The old defaultProps.js file just has the following content:
import Prism from "prism-react-renderer/prism";
import theme from "prism-react-renderer/themes/duotoneDark"; // Adjust the theme import based on availability
<Highlight Prism={Prism} theme={theme} code={code} language={language ?? "text"}>
{/* rest of your component code */}
</Highlight>
I haven't found this to really do anything? so I simply removed it.
@@ -9,7 +9,7 @@ import { | |||
} from "@docusaurus/theme-common"; | |||
import { | |||
isActiveSidebarItem, | |||
findFirstCategoryLink, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is no longer being exported. I think the replacement covers the functionality of the old function.
…rium into docusaurus-v3
| `before-reset` | This stage executes before reset. | | | ||
| Stage | Description | | ||
| ---- | ---- | | ||
| `rootfs` | This is the earliest stage, running before switching to root. It happens right after the root is mounted in /sysroot and before applying the immutable rootfs configuration. This stage is executed over initrd root, no chroot is applied. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'rootfs'?
| `before-reset` | This stage executes before reset. | | | ||
| Stage | Description | | ||
| ---- | ---- | | ||
| `rootfs` | This is the earliest stage, running before switching to root. It happens right after the root is mounted in /sysroot and before applying the immutable rootfs configuration. This stage is executed over initrd root, no chroot is applied. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'initrd'?
| `before-reset` | This stage executes before reset. | | | ||
| Stage | Description | | ||
| ---- | ---- | | ||
| `rootfs` | This is the earliest stage, running before switching to root. It happens right after the root is mounted in /sysroot and before applying the immutable rootfs configuration. This stage is executed over initrd root, no chroot is applied. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'chroot'?
| Stage | Description | | ||
| ---- | ---- | | ||
| `rootfs` | This is the earliest stage, running before switching to root. It happens right after the root is mounted in /sysroot and before applying the immutable rootfs configuration. This stage is executed over initrd root, no chroot is applied. | | ||
| `initramfs` | This is still an early stage, running before switching to root. Here you can apply changes to the booting setup of Elemental. Despite executing this before switching to root, this invocation is chrooted into the target root after the immutable rootfs is set up and ready. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'chrooted'?
| Stage | Description | | ||
| ---- | ---- | | ||
| `rootfs` | This is the earliest stage, running before switching to root. It happens right after the root is mounted in /sysroot and before applying the immutable rootfs configuration. This stage is executed over initrd root, no chroot is applied. | | ||
| `initramfs` | This is still an early stage, running before switching to root. Here you can apply changes to the booting setup of Elemental. Despite executing this before switching to root, this invocation is chrooted into the target root after the immutable rootfs is set up and ready. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'rootfs'?
| ---- | ---- | | ||
| `rootfs` | This is the earliest stage, running before switching to root. It happens right after the root is mounted in /sysroot and before applying the immutable rootfs configuration. This stage is executed over initrd root, no chroot is applied. | | ||
| `initramfs` | This is still an early stage, running before switching to root. Here you can apply changes to the booting setup of Elemental. Despite executing this before switching to root, this invocation is chrooted into the target root after the immutable rootfs is set up and ready. | | ||
| `boot` | This stage executes after initramfs has switched to root and during the systemd boot-up process. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'initramfs'?
| ---- | ---- | | ||
| `rootfs` | This is the earliest stage, running before switching to root. It happens right after the root is mounted in /sysroot and before applying the immutable rootfs configuration. This stage is executed over initrd root, no chroot is applied. | | ||
| `initramfs` | This is still an early stage, running before switching to root. Here you can apply changes to the booting setup of Elemental. Despite executing this before switching to root, this invocation is chrooted into the target root after the immutable rootfs is set up and ready. | | ||
| `boot` | This stage executes after initramfs has switched to root and during the systemd boot-up process. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'systemd'?
| `rootfs` | This is the earliest stage, running before switching to root. It happens right after the root is mounted in /sysroot and before applying the immutable rootfs configuration. This stage is executed over initrd root, no chroot is applied. | | ||
| `initramfs` | This is still an early stage, running before switching to root. Here you can apply changes to the booting setup of Elemental. Despite executing this before switching to root, this invocation is chrooted into the target root after the immutable rootfs is set up and ready. | | ||
| `boot` | This stage executes after initramfs has switched to root and during the systemd boot-up process. | | ||
| `fs` | This stage is executed when fs is mounted and is guaranteed to have access to the state and persistent partitions ( COS_STATE and COS_PERSISTENT respectively). | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'fs'?
| `after-install` | This stage executes after the installation of the OS. | | ||
| `after-install-chroot` | This stage executes after the installation of the OS ends. | | ||
| `after-upgrade` | This stage executes after the OS upgrade ends. | | ||
| `after-upgrade-chroot` | This stage executes after the OS upgrade ends (chroot call). | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'chroot'?
| `after-upgrade` | This stage executes after the OS upgrade ends. | | ||
| `after-upgrade-chroot` | This stage executes after the OS upgrade ends (chroot call). | | ||
| `after-reset` | This stage executes after the OS resets. | | ||
| `after-reset-chroot` | This stage executes after the OS resets (chroot call). | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'chroot'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved 🚀
🎉 This PR is included in version 4.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 4.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Describe the Change
This PR upgrades the docusaurus version used by the site to docusaurus v3.0.1
Review Changes
💻 Add Preview URL
🎫 Jira Ticket