Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide missing Autocale information #1857

Merged
merged 11 commits into from
Dec 22, 2023

Conversation

ritawatson
Copy link
Contributor

@ritawatson ritawatson commented Nov 30, 2023

Describe the Change

This PR provides missing autoscaler information in the Azure IaaS doc and refactors the doc.

Review Changes

💻 Preview Autoscale section

🎫 DOC-897

Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit e19cc6b
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/6585ca7b87fbb40008bf0c0b
😎 Deploy Preview https://deploy-preview-1857--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ritawatson ritawatson added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-1 Backport change to version 4.1 documentation Improvements or additions to documentation labels Nov 30, 2023
@ritawatson ritawatson marked this pull request as ready for review November 30, 2023 20:13
@ritawatson ritawatson requested a review from a team as a code owner November 30, 2023 20:13
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ritawatson here are the questions that came to mind when reviewing the content for the autoscaler

Q: Why would I need to enable Autoscale in Azure? Is because this is the only way to get dynamic worload scaling of nodes with Azure IaaS clusters?

Q: How does Azure autoscaler and Palette coordinate tasks, or worded differently, how do they work together.

Q: Once I create an autoscaler in Azure? How can I validate it's working?


## Force Delete a Cluster
Basic autoscaling options are available for host-based scaling when you create your scale set. However, to create custom autoscale rules based on metrics or a schedule, use **Custom autoscale**. To learn how you can scale resources based on metrics you define, refer to Microsoft's [Get started with Autoscale in Azure](https://learn.microsoft.com/en-us/azure/azure-monitor/autoscale/autoscale-get-started) reference guide.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Vale.Spelling] Did you really mean 'autoscale'?

@ritawatson ritawatson requested review from deepaks34 and removed request for deepaks34 December 1, 2023 16:50
@karl-cardenas-coding karl-cardenas-coding marked this pull request as draft December 20, 2023 00:06
@karl-cardenas-coding karl-cardenas-coding marked this pull request as ready for review December 22, 2023 17:27
@karl-cardenas-coding
Copy link
Contributor

Other changes from PR #1798 are carried over into this PR.

@karl-cardenas-coding karl-cardenas-coding merged commit e186fc4 into master Dec 22, 2023
10 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the provide-missing-autoscale branch December 22, 2023 17:56
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Dec 22, 2023
* Copy textual content to file in new branch.

* Add images to this branch.

* Minor revisions

* Shorten heading

* Minor revision

* Clarify autoscale heading

* docs: removed autoscaling from Iaas

* docs: added autoscale to Vale

* docs: removal update

* docs: added account registration from other PR

---------

Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit e186fc4)
@vault-token-factory-spectrocloud
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
version-4-0 Backport failed because of merge conflicts
version-3-4 Backport failed because of merge conflicts

You might need to backport the following PRs to version-3-4:
- docs: added keycloak How-to (#1839)
- Refactor/restructure cluster & app profiles sections (#1551)
- docs: updated URLs to use file path context
version-4-1

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 1857

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

karl-cardenas-coding added a commit that referenced this pull request Dec 22, 2023
* Copy textual content to file in new branch.

* Add images to this branch.

* Minor revisions

* Shorten heading

* Minor revision

* Clarify autoscale heading

* docs: removed autoscaling from Iaas

* docs: added autoscale to Vale

* docs: removal update

* docs: added account registration from other PR

---------

Co-authored-by: Karl Cardenas <[email protected]>
karl-cardenas-coding added a commit that referenced this pull request Dec 22, 2023
* Copy textual content to file in new branch.

* Add images to this branch.

* Minor revisions

* Shorten heading

* Minor revision

* Clarify autoscale heading

* docs: removed autoscaling from Iaas

* docs: added autoscale to Vale

* docs: removal update

* docs: added account registration from other PR

---------

Co-authored-by: Karl Cardenas <[email protected]>
karl-cardenas-coding pushed a commit that referenced this pull request Dec 22, 2023
* Copy textual content to file in new branch.

* Add images to this branch.

* Minor revisions

* Shorten heading

* Minor revision

* Clarify autoscale heading

* docs: removed autoscaling from Iaas

* docs: added autoscale to Vale

* docs: removal update

* docs: added account registration from other PR

---------

Co-authored-by: Karl Cardenas <[email protected]>
(cherry picked from commit e186fc4)

Co-authored-by: Rita Watson <[email protected]>
This was referenced Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants