Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline Docs #1830

Merged
merged 14 commits into from
Nov 21, 2023
Merged

Offline Docs #1830

merged 14 commits into from
Nov 21, 2023

Conversation

karl-cardenas-coding
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding commented Nov 20, 2023

Describe the Change

This PR adds documentation and logic for how to access the offline documentation.

Review Changes

💻 Preview URL

🎫 Jira Ticket

@karl-cardenas-coding karl-cardenas-coding added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-4-1 Backport change to version 4.1 labels Nov 20, 2023
@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner November 20, 2023 23:23
Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit f9e1f28
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/655bf04e1ee2be0008e9e576
😎 Deploy Preview https://deploy-preview-1830--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@lennessyy lennessyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - just a minor suggestion about the callout type

@karl-cardenas-coding karl-cardenas-coding enabled auto-merge (squash) November 20, 2023 23:57
@karl-cardenas-coding karl-cardenas-coding merged commit bfaa981 into master Nov 21, 2023
7 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the offline-image branch November 21, 2023 00:00
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 21, 2023
* chore: verify CI/CD

* save

* chore: verify CI/CD-2

* chore: verify CI/CD-2

* chore: verify CI/CD-2

* ci: update correct file arg

* chore: verify CI/CD-3

* chore: verify CI/CD-4

* chore: verify CI/CD-5

* chore: verify CI/CD-5

* docs: added documentation

* docs: clarified container spect

* Apply suggestions from code review

Co-authored-by: Lenny Chen <[email protected]>

---------

Co-authored-by: Lenny Chen <[email protected]>
(cherry picked from commit bfaa981)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 21, 2023
* chore: verify CI/CD

* save

* chore: verify CI/CD-2

* chore: verify CI/CD-2

* chore: verify CI/CD-2

* ci: update correct file arg

* chore: verify CI/CD-3

* chore: verify CI/CD-4

* chore: verify CI/CD-5

* chore: verify CI/CD-5

* docs: added documentation

* docs: clarified container spect

* Apply suggestions from code review

Co-authored-by: Lenny Chen <[email protected]>

---------

Co-authored-by: Lenny Chen <[email protected]>
(cherry picked from commit bfaa981)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-0
version-4-1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

karl-cardenas-coding added a commit that referenced this pull request Nov 21, 2023
* chore: verify CI/CD

* save

* chore: verify CI/CD-2

* chore: verify CI/CD-2

* chore: verify CI/CD-2

* ci: update correct file arg

* chore: verify CI/CD-3

* chore: verify CI/CD-4

* chore: verify CI/CD-5

* chore: verify CI/CD-5

* docs: added documentation

* docs: clarified container spect

* Apply suggestions from code review

Co-authored-by: Lenny Chen <[email protected]>

---------

Co-authored-by: Lenny Chen <[email protected]>
(cherry picked from commit bfaa981)

Co-authored-by: Karl Cardenas <[email protected]>
karl-cardenas-coding added a commit that referenced this pull request Nov 21, 2023
* chore: verify CI/CD

* save

* chore: verify CI/CD-2

* chore: verify CI/CD-2

* chore: verify CI/CD-2

* ci: update correct file arg

* chore: verify CI/CD-3

* chore: verify CI/CD-4

* chore: verify CI/CD-5

* chore: verify CI/CD-5

* docs: added documentation

* docs: clarified container spect

* Apply suggestions from code review

Co-authored-by: Lenny Chen <[email protected]>

---------

Co-authored-by: Lenny Chen <[email protected]>
(cherry picked from commit bfaa981)

Co-authored-by: Karl Cardenas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants