Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc allow non fips packs in vertex pem 3652 #1680

Merged

Conversation

ritawatson
Copy link
Contributor

@ritawatson ritawatson commented Oct 19, 2023

Describe the Change

This PR addresses the ability to add non-FIPS infrastructure packs. Previously, tenant users could only add non-FIPS add-on packs. This PR also addresses the changed toggle name in Tenant Settings from Allow non-FIPS add-on packs to Allow non-FIPS packs, replaces a screenshot, and identifies the registry needed for non-FIPS infrastructure packs.

This PR also adds how-tos to add a registry at the system and tenent levels.

Review Changes

💻 Changed Pages:
Enable non-FIPS Settings
Use non-FIPS Packs

Added Pages:
Add a Registry (VerteX section)
Add System-Level Registry (Under Self-Hosted Palette, System Management - this is a non-VerteX copy of the above)
Add Tenant-Level Registry (under Tenant Administration)

🎫 Jira Ticket

@ritawatson ritawatson requested a review from a team as a code owner October 19, 2023 00:12
@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit e8f7437
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/6534423ceb7fd800086d5491
😎 Deploy Preview https://deploy-preview-1680--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ritawatson ritawatson changed the base branch from master to release-4-1 October 19, 2023 00:15
@ritawatson ritawatson added the documentation Improvements or additions to documentation label Oct 19, 2023
@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 36.3%, saving 57.77 KB.

Filename Before After Improvement Visual comparison
static/assets/docs/images/vertex_use-non-fips-settings_nonFips-packs.png 158.98 KB 101.21 KB -36.3% View diff

503 images did not require optimisation.

Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are great but we do need to add the documents for how to add a registry. Rita, I'm gonna share a recording with you that shows you how to do this.

Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few things we need to tidy up.


Use the following steps to add a system-level OCI registry.

To add our non-FIPS registries, refer to the table in the [Use non-FIPS Packs](../system-management/enable-non-fips-settings/use-non-fips-addon-packs.md) guide for endpoint and base path details. You will need to repeat these steps and specify the base path for each repository you want to target in the registry.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This information don't belong here. This needs to be generic. This guidance should go before the table with the non fips registries in the use non-FIPS packs page.

@karl-cardenas-coding karl-cardenas-coding merged commit 48d1b40 into release-4-1 Oct 21, 2023
@karl-cardenas-coding karl-cardenas-coding deleted the doc-allow-non-fips-packs-in-vertex-pem-3652 branch October 21, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants