Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC config for vclusters ppd 1328 #1626

Merged
merged 14 commits into from
Oct 3, 2023

Conversation

ritawatson
Copy link
Contributor

@ritawatson ritawatson commented Sep 28, 2023

Describe the Change

This PR documents how to configure OIDC for virtual clusters.

Review Changes

💻 Preview

🎫 Jira Ticket

@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 243f953
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/651c66ba747d950008e2f6aa
😎 Deploy Preview https://deploy-preview-1626--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ritawatson ritawatson added documentation Improvements or additions to documentation backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport labels Sep 28, 2023
@ritawatson ritawatson marked this pull request as ready for review September 29, 2023 01:26
@ritawatson ritawatson requested a review from a team as a code owner September 29, 2023 01:26
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great guide I just have some minor nitpicking and points I want us to clarify or expand on.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Images automagically compressed by Calibre's image-actions

Compression reduced images by 34.2%, saving 74.76 KB.

Filename Before After Improvement Visual comparison
static/assets/docs/images/clusters_palette-virtual-clusters_configure-vcluster-oidc.png 218.83 KB 144.07 KB -34.2% View diff

480 images did not require optimisation.

Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rita, can you add the same OIDC update to the generic Kubernetes pack.

@ritawatson ritawatson merged commit c8768a7 into master Oct 3, 2023
9 checks passed
@ritawatson ritawatson deleted the oidc-config-for-vclusters-ppd-1328 branch October 3, 2023 20:00
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Oct 3, 2023
* Draft how-to, add diagram

* Fix local server error

* Add bold to UI element.

* Update screenshot and examples

* Incorporate review comments

* Optimised images with calibre/image-actions

* Applied more suggestions

* Did some final touch up, added link from PXK.

* Add clusterGroup.update permission.

* Add link in PXK-E doc to this doc.

* Add missing italic and missing word

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c8768a7)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

ritawatson added a commit that referenced this pull request Oct 3, 2023
* Draft how-to, add diagram

* Fix local server error

* Add bold to UI element.

* Update screenshot and examples

* Incorporate review comments

* Optimised images with calibre/image-actions

* Applied more suggestions

* Did some final touch up, added link from PXK.

* Add clusterGroup.update permission.

* Add link in PXK-E doc to this doc.

* Add missing italic and missing word

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c8768a7)

Co-authored-by: Rita Watson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-4-0 Backport change to version 4.0 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants