Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Signing #17

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Image Signing #17

merged 2 commits into from
Jan 23, 2024

Conversation

karl-cardenas-coding
Copy link
Contributor

Describe the Change

This PR adds image signing to the Docker images.

Review Changes

🎫 DOC-962

@karl-cardenas-coding karl-cardenas-coding added documentation Improvements or additions to documentation enhancement New feature or request CI/CD CI/CD related changes labels Jan 23, 2024
@karl-cardenas-coding karl-cardenas-coding changed the title fix: added image signing DOC-962 Image Signing Jan 23, 2024
caroldelwing
caroldelwing approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@caroldelwing caroldelwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just small suggestions.

README.md Show resolved Hide resolved
docs/image-verification.md Outdated Show resolved Hide resolved
docs/image-verification.md Outdated Show resolved Hide resolved
@karl-cardenas-coding karl-cardenas-coding merged commit e5c2912 into main Jan 23, 2024
3 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the image-signing branch January 23, 2024 17:18
github-actions bot pushed a commit that referenced this pull request Jan 23, 2024
@semantic-release-bot
chore(release): 1.1.1 [skip ci]
896386a 
## [1.1.1](v1.1.0...v1.1.1) (2024-01-23)

### Bug Fixes

* added image signing DOC-962 ([a9b33e3](a9b33e3))
* DOC-962 merge pull request [#17](#17) from spectrocloud/image-signing ([e5c2912](e5c2912))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caroldelwing caroldelwing caroldelwing approved these changes

Assignees
No one assigned
Labels
CI/CD CI/CD related changes documentation Improvements or additions to documentation enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karl-cardenas-coding @caroldelwing