Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] PCP-22: Boostrap and CAPI changes #53

Open
wants to merge 1 commit into
base: spectro-v1.3.1
Choose a base branch
from

Conversation

AmitSahastra
Copy link

Minor changes

PCP-22: CAPI changes

Code cleanup

Added takeOverCluster in ClusterSpec

Added takeOverCluster in ClusterSpec

Spectro generated changes

Update cluster_types.go

Update kubeadmconfig_controller.go

Update controller.go

Update kubeadm_control_plane_webhook.go

Added takeOverCluster in Annotations

Update kubeadm_control_plane_webhook.go

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Minor changes

PCP-22: CAPI changes

Code cleanup

Added takeOverCluster in ClusterSpec

Added takeOverCluster in ClusterSpec

Spectro generated changes

Update cluster_types.go

Update kubeadmconfig_controller.go

Update controller.go

Update kubeadm_control_plane_webhook.go

Added takeOverCluster in Annotations

Update kubeadm_control_plane_webhook.go
@spectro-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AmitSahastra
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spectro-prow
Copy link

Hi @AmitSahastra. Thanks for your PR.

I'm waiting for a spectrocloud member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants