Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCP-2735: EKS cluster deletion stuck with error failed to delete OIDC provider #898

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

AmitSahastra
Copy link

@AmitSahastra AmitSahastra commented Mar 27, 2024

What is the purpose of the pull request

Issue:
EKS cluster deletion stuck with error failed to delete OIDC provider

Cause:
Data point for deleting oidc provider in delete reconcile flow now also considers OidcProviderAnnotation in awsmanagedControlPlane to handle cases like force pivot.
After delete annotation need to reset to avoid delete try again.

Implementation

Fix: Remote ARN from OidcProviderAnnotation after first successful deletetion.

Committer checklist

Verified on:

  • EKS

Special notes for your reviewer:

Checklist:

  • squashed commits

@spectro-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AmitSahastra, sadysnaat
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sadysnaat sadysnaat merged commit 4ba2a10 into spectro-master Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants