Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cert-manager annotation to pod-identity-webhook mutatingwebhookco… #875

Conversation

stefanSpectro
Copy link

What type of PR is this?
/kind bug

What this PR does / why we need it:

We need this PR so that when certs are changed cert-manager knows to update the ca information stored for pod-identity-webhook MutatingWebhookConfiguration. This is done by ensuring the correct cert-manager annotation is present on the resource so that it can pull updated cert information from the given Secret.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
https://spectrocloud.atlassian.net/browse/PCP-2363

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@spectro-prow
Copy link

@stefanSpectro: The label(s) kind/bug cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?
/kind bug

What this PR does / why we need it:

We need this PR so that when certs are changed cert-manager knows to update the ca information stored for pod-identity-webhook MutatingWebhookConfiguration. This is done by ensuring the correct cert-manager annotation is present on the resource so that it can pull updated cert information from the given Secret.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
https://spectrocloud.atlassian.net/browse/PCP-2363

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spectro-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stefanSpectro
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants