Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add postgresql #111

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Add postgresql #111

merged 3 commits into from
Dec 20, 2023

Conversation

oz123
Copy link
Contributor

@oz123 oz123 commented Dec 20, 2023

No description provided.

@oz123 oz123 requested a review from TylerGillson December 20, 2023 15:31
@oz123 oz123 changed the base branch from main to two-node December 20, 2023 15:31
TylerGillson
TylerGillson approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@TylerGillson TylerGillson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for testing, but would be ideal if you refactored the duplicate code into a common helper

@oz123 oz123 merged commit 6bc814b into two-node Dec 20, 2023
@oz123 oz123 deleted the add-postgresql branch December 20, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerGillson TylerGillson TylerGillson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oz123 @TylerGillson