Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New key-value mapping to simplify header decoding (& fix CI code check) #61

Merged
merged 13 commits into from
Jan 2, 2023

Conversation

philipp-baumann
Copy link
Member

@philipp-baumann philipp-baumann commented Dec 18, 2022

addresses #60

@philipp-baumann
Copy link
Member Author

promt-create-dataset

@philipp-baumann
Copy link
Member Author

philipp-baumann commented Dec 18, 2022

We now gracefully by encouraging development support :-)

stop-proactively-header-mapping

@philipp-baumann
Copy link
Member Author

philipp-baumann commented Dec 18, 2022

@ThomasKnecht have tested the new key-map logic for all internal test files. We are successful on all, except the new FT-IR remote sensing device. You can ignore the ci code check warning for now. There seems to be an old cache because I forgot to merge the last pr merged in main (have forced in this branch).

@philipp-baumann philipp-baumann added bug Something isn't working feature New feature or request key work labels Dec 18, 2022
@philipp-baumann
Copy link
Member Author

Currently there is no other workaround than relying on classical pre-commit action instead of bot-like auto-fixing PRs via pre-commit-ci-lite => see also pre-commit-ci/issues#13 and lorenzwalthert/precommit#450

@philipp-baumann philipp-baumann changed the title New key-value mapping to simplify header decoding New key-value mapping to simplify header decoding (& CI code check) Dec 23, 2022
@philipp-baumann philipp-baumann changed the title New key-value mapping to simplify header decoding (& CI code check) New key-value mapping to simplify header decoding (& fix CI code check) Dec 23, 2022
@philipp-baumann
Copy link
Member Author

@ThomasKnecht FYI current main is now merged. CI runs now there, but just not yet in this PR. Locally this PR branch passes 💯

2022-12-24_01-06_pre-commit-run-all

@philipp-baumann
Copy link
Member Author

philipp-baumann commented Dec 24, 2022

FYI I have pushed some more docs into main directly. Now mostly finished with describing return value (parsed and returned OPUS blocks. => see also https://spectral-cockpit.github.io/opusreader2/reference/parse_opus.html . Feel free to directly correct doc etc. here by pushing directly. Once this PR is merged I, I would

a) complete the docs of parse_opus() and transfer the description of output list to read_opus().

Then b) Also add support for the FT-IR remote sensing device for greenhouse gas measurements (new block types create_dataset()).

c) I'd add also some more nice parameter names for Bruker Tango (We cannot yet read all of the report fields from the OPUS QUANT2 module https://www.bruker.com/en/products-and-solutions/infrared-and-raman/opus-spectroscopy-software/quantification.html ; not super important (do own modeling and infrastructure anyways) but I vaguely remember you might have once expanded the header parsing algorithm right ;-)?).

=> Finally, my suggestion is that we bump from currently "dev" 0.0.0.9002 to to version 0.1.0 using "minor" and make a release on GH. @ThomasKnecht anything else to? Does that sound good to you?

@philipp-baumann philipp-baumann merged commit c4be741 into main Jan 2, 2023
@philipp-baumann philipp-baumann deleted the opt-55-simplify-create-dataset branch February 8, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature New feature or request key work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants