-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New key-value mapping to simplify header decoding (& fix CI code check) #61
Conversation
@ThomasKnecht have tested the new key-map logic for all internal test files. We are successful on all, except the new FT-IR remote sensing device. You can ignore the ci code check warning for now. There seems to be an old cache because I forgot to merge the last pr merged in main (have forced in this branch). |
Currently there is no other workaround than relying on classical pre-commit action instead of bot-like auto-fixing PRs via pre-commit-ci-lite => see also pre-commit-ci/issues#13 and lorenzwalthert/precommit#450 |
@ThomasKnecht FYI current main is now merged. CI runs now there, but just not yet in this PR. Locally this PR branch passes 💯 |
FYI I have pushed some more docs into main directly. Now mostly finished with describing return value (parsed and returned OPUS blocks. => see also https://spectral-cockpit.github.io/opusreader2/reference/parse_opus.html . Feel free to directly correct doc etc. here by pushing directly. Once this PR is merged I, I would a) complete the docs of Then b) Also add support for the FT-IR remote sensing device for greenhouse gas measurements (new block types c) I'd add also some more nice parameter names for Bruker Tango (We cannot yet read all of the report fields from the OPUS QUANT2 module https://www.bruker.com/en/products-and-solutions/infrared-and-raman/opus-spectroscopy-software/quantification.html ; not super important (do own modeling and infrastructure anyways) but I vaguely remember you might have once expanded the header parsing algorithm right ;-)?). => Finally, my suggestion is that we bump from currently "dev" 0.0.0.9002 to to version 0.1.0 using "minor" and make a release on GH. @ThomasKnecht anything else to? Does that sound good to you? |
addresses #60