Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled accurate near plane calculation #3778

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Enabled accurate near plane calculation #3778

merged 1 commit into from
Jan 9, 2025

Conversation

AlexandruPopovici
Copy link
Contributor

Description & motivation

Using NearPlaneCalculation.ACCURATE in the camera controller

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

📸 Preview service has generated an image.

@AlexandruPopovici AlexandruPopovici merged commit 58a6795 into main Jan 9, 2025
42 of 44 checks passed
@AlexandruPopovici AlexandruPopovici deleted the alex/accurate-near-plane branch January 9, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didimitrie didimitrie didimitrie approved these changes

@benjaminvo benjaminvo Awaiting requested review from benjaminvo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexandruPopovici @didimitrie