feat(fe2): scope comment mentions to parent project collaborators #3635
Conversation
fabis94
commented
Dec 5, 2024
fabis94
commented
- various related fixes
|
📸 Preview service has generated an image. |
| """ | ||
| Look up server users | ||
| """ | ||
| users(input: UsersRetrievalInput!): UserSearchResultCollection! |
There was a problem hiding this comment.
The param list for userSearch was already too long and I expect it to grow in the future. Plus, why would we want to allow (non-admin)users to search for archived users?
|
📸 Preview service has generated an image. |
| @@ -151,7 +151,7 @@ function buildEmailTemplateParams( | |||
| objectId, | |||
| commitId | |||
| }) | |||
| const url = new URL(commentRoute, getBaseUrl()).toString() | |||
| const url = new URL(commentRoute, getFrontendOrigin()).toString() | |||
There was a problem hiding this comment.
mention email cta links were busted locally (only where FE and BE origin differs afaik)
| ), | ||
| knex.raw(`(array_agg("user_emails"."verified"))[1] as verified`) | ||
| knex.raw(`(array_agg(??))[1] as "verified"`, [UserEmails.col.verified]), |
There was a problem hiding this comment.
@alemagio it was this way before already, but i'm wondering if this logic is valid - surely we should look for the first verified email, instead of just the first email that exists? otherwise we risk marking the user as unverified, when one of their emails is verified
fabis94
requested review from
alemagio,
Mikehrn,
gjedlicska and
andrewwallacespeckle
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
