-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: base quickstart on remote existing target #999
Merged
Merged
+315
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adaam2
force-pushed
the
feat/quickstart-existing-spec
branch
2 times, most recently
from
October 7, 2024 12:53
303e234
to
4a0e465
Compare
mfbx9da4
reviewed
Oct 7, 2024
mfbx9da4
reviewed
Oct 7, 2024
mfbx9da4
reviewed
Oct 7, 2024
mfbx9da4
reviewed
Oct 7, 2024
simplesagar
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for the concept
mfbx9da4
reviewed
Oct 14, 2024
adaam2
force-pushed
the
feat/quickstart-existing-spec
branch
from
November 22, 2024 13:40
4a0e465
to
4a17f4a
Compare
@ryan-timothy-albert I've updated this now so that it checks if a namespace has a |
adaam2
force-pushed
the
feat/quickstart-existing-spec
branch
from
November 22, 2024 17:00
831a41f
to
58e8674
Compare
ryan-timothy-albert
approved these changes
Nov 22, 2024
adaam2
force-pushed
the
feat/quickstart-existing-spec
branch
from
November 25, 2024 14:47
686c0f9
to
f96f463
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to bootstrap a new target using a pre-existing specification hosted on Speakeasy's registry. The CLI will now show the most recent 5 targets that have been interacted with (based on the CLI event stream).
If there are any recent target candidates in the workspace, then the user will be presented with the option to choose from an existing SDK or create from scratch at the beginning of Quickstart. If there are no previous generations in a workspace, then the existing "new user" flow will be shown where the user can enter a filepath to a spec:
Then selecting from the list of recent SDKs:
(n.b the look and feel of the select list in the 2nd screenshot will change / look much better once the corresponding charmbracelet/huh#424 pr has been merged)
The end result is that a new workflow file is created that references the existing Registry URI for the spec from the previous target
Next steps
gen.yaml