Fix URLs to OSI website #2616
Fix URLs to OSI website #2616
Conversation
|
@ziemek99 - Thanks for pointing this out and proposing a solution Rather than replacing the current OSI reference, I would suggest we add a new reference and keep the original so that tools the use the URL's to correlate license information won't break. We'll end up with one live and one "not so live" URL. Note, this may appear unnecessary to human users, but for many tools it is quite important to correlate licenses with URLs that are no longer used. |
I suppose it only applies to files in
Is there any required order to keep? For aesthetic reasons I'd like to keep "not so live" URLs under the live ones. If that'd break compatibility, though, I can keep the order of the previous entries and add current URLs underneath. Another (better) solution would be fixing the parser logic so it follows any HTTP redirects and doesn't mark these URLs as no longer live. |
Correct - only the
I don't think order matters.
Possibly - Although it is nice having the correct (non-redirected) URLs added for 2 reasons:
Flagging these on the website gives us a chance to add the new URL. There may be a better way to flag them, but this did result in an very welcome update to the |
ziemek99
force-pushed
the
osi-crossref-fix
branch
from
f38002f
to
d0300ec
Compare
| @@ -48,7 +48,7 @@ There are two mandatory attributes for every `<license>` and `<exception>` tag: | |||
| There are two additional highly encouraged attributes which are technically optional: | |||
| * `listVersionAdded`: in which release version of the SPDX License List was the license first added, e.g., "3.24.0". | |||
| * Typically you'll check the currently-released version at https://github.com/spdx/license-list-XML/releases and increment the minor version by 1 for a new license. E.g., when last release is "3.24.0" you add there "3.25.0". | |||
| * `isOsiApproved` (for licenses, not exceptions): either "true" or "false" based on whether this license has been approved by the [Open Source Initiative](https://opensource.org/licenses/alphabetical) | |||
| * `isOsiApproved` (for licenses, not exceptions): either "true" or "false" based on whether this license has been approved by the [Open Source Initiative](https://opensource.org/licenses) | |||
There was a problem hiding this comment.
This should be just https://opensource.org/license (without the trailing s.
|
Otherwise LGTM. |
Apparently OSI webite was restructured a bit some time ago. Old links to license info return HTTP 301 redirects. While it's not a problem for a browser to follow such link, some kind of parser logic at SPDX erroneously detects such URL as "no longer live" when you see "Other web pages for this license" on SPDX website.