Add missing tag methods #326
Closed
+37
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@freekmurze @rubenvanassche Could someone please approve this PR? I understand you guys are super busy but these would be very much appreciated. Thanks for all the work guys! |
|
@Baspa If you add some tests we'll merge it back in! |
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v4 the Mailchimp driver contained a few methods to manage tags. Because probably the Mailcoach driver doesn't support tags they were removed. Can they be added again? I understand they're driver specific in this case but that shouldn't be a problem right?
Please let me know if this can be added again. If so I'm happy to add tests as well.