Support for PHP 8.4 (#33)

* Parameters with null default must be nullable * Add .phpunit.result.cache to .gitignore * Add testing for PHP 8.1 -> 8.4
spatie · Dec 2, 2024 · 0969667 · 0969667
1 parent 8360415
commit 0969667
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -3,3 +3,4 @@ composer.lock
 docs
 vendor
 coverage
+.phpunit.result.cache
diff --git a/.travis.yml b/.travis.yml
@@ -5,6 +5,10 @@ php:
   - 7.2
   - 7.3
   - 8.0
+  - 8.1
+  - 8.2
+  - 8.3
+  - 8.4
 
 env:
   matrix:

diff --git a/src/RateLimiterMiddleware.php b/src/RateLimiterMiddleware.php
@@ -14,7 +14,7 @@ private function __construct(RateLimiter $rateLimiter)
         $this->rateLimiter = $rateLimiter;
     }
 
-    public static function perSecond(int $limit, Store $store = null, Deferrer $deferrer = null): RateLimiterMiddleware
+    public static function perSecond(int $limit, ?Store $store = null, ?Deferrer $deferrer = null): RateLimiterMiddleware
     {
         $rateLimiter = new RateLimiter(
             $limit,
@@ -26,7 +26,7 @@ public static function perSecond(int $limit, Store $store = null, Deferrer $defe
         return new static($rateLimiter);
     }
 
-    public static function perMinute(int $limit, Store $store = null, Deferrer $deferrer = null): RateLimiterMiddleware
+    public static function perMinute(int $limit, ?Store $store = null, ?Deferrer $deferrer = null): RateLimiterMiddleware
     {
         $rateLimiter = new RateLimiter(
             $limit,
-Original file line number
+Diff line change
@@ Expand Up / @@ -3,3 +3,4 @@ composer.lock @@
     docs
     vendor
     coverage
+    .phpunit.result.cache