Fail if unserialize is unable to parse output of child process

[MarcHagen]

In ParallelProcess in getOutput() is checked if the unserialize is successful.
When it fails, is sets the errorOutput to the process output.

async/src/Process/ParallelProcess.php

Lines 71 to 75 in c270e69

	$this->output = @unserialize(base64_decode($processOutput));
	if (! $this->output) {
	$this->errorOutput = $processOutput;
	}

But this is not validated anymore because the check is already passed.

async/src/Process/ProcessCallbacks.php

Lines 35 to 50 in c270e69

	public function triggerSuccess()
	{
	if ($this->getErrorOutput()) {
	$this->triggerError();
	return;
	}
	$output = $this->getOutput();
	foreach ($this->successCallbacks as $callback) {
	call_user_func_array($callback, [$output]);
	}
	return $output;
	}

Moving the getOutput() before the error output check will ensure all error output cases are handled properly.

Adding extra checks on the output of the child processes, we can ensure the output of the task is not false or null, falsely triggering the errorOutput.
By changing the ChildRuntime output to a predictable array ensures we can check if something is wrong with parsing the child processes output.

[spatie-bot]

Dear contributor,

because this pull request seems to be inactive for quite some time now, I've automatically closed it. If you feel this pull request deserves some attention from my human colleagues feel free to reopen it.

[MarcHagen]

@spatie-bot your human colleagues seem not to care, either do you by not poking them first.