Use force=True with copyfile

[gabalafou]

Fixes #818.

[pep8speaks]

Hello @gabalafou! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-11-03 20:33:35 UTC

[gabalafou]

I manually checked this in a few different ways, but the general idea was to start with a repo where I could reproduce #818. Then:

• set sphinx to version 8, set nbsphinx to my modified version, observe that the bug described in Possible bug: misc.copy_overwrite warning  #818 goes way
• set sphinx to version 7, set nbsphinx to my modified version, everything ok

[mgeier]

Thanks for this PR!

The test failures are unrelated, I'm trying to find out what to do about them in sphinx-doc/sphinx#13083.

[gabalafou]

Thanks for the pointers!

Re: test failures. That looks frustrating!

[mgeier]

Now that we have this as a function, you could get rid of the additional line above by directly calling the function here (and again below):

Suggested change

	**overwrite)
	**backwards_compat_overwrite())

What do you think about this?

[mgeier]

Thanks!