Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update broken links in README #155

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

dustin-jw
Copy link
Contributor

@dustin-jw dustin-jw commented Feb 29, 2024

Description

There were two links that caused issues for folks getting started with this starter template. The link to generate a new repo was broken because of its relative path not accounting for things like /blob/main/ in the README URL. There was also a localhost link with https for the protocol, which caused browsers to show error messages about site security.

To Validate

  1. Make sure all PR Checks have passed
  2. Check that the localhost links in the README use http instead of https
  3. Click the link to generate a new repo and confirm that it leads to the page for creating a repo from the template

Copy link
Member

@jonoliver jonoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dustin!

@dustin-jw dustin-jw merged commit 75dbeef into main Feb 29, 2024
2 checks passed
@dustin-jw dustin-jw deleted the docs--readme-corrections branch February 29, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants