Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: State class loop mixin #70

Merged
merged 1 commit into from
Feb 17, 2021
Merged

feat: State class loop mixin #70

merged 1 commit into from
Feb 17, 2021

Conversation

zastrow
Copy link
Contributor

@zastrow zastrow commented Jan 25, 2021

This addresses issue #68 by adding a new feature, the sparkle state loop mixin. This mixin is a private mixin for the color system to generate state-based class names and work with the media query class suffixes. A test has been added to verify the mixin output.

To verify this code:

  1. Pull down this branch
  2. If it has been a while, run npm install
  3. Run npm start to generate the CSS file
  4. Run npm test to verify tests pass
  5. Open the W3C CSS Validator
  6. Upload the generated CSS file: ./sparkle/styleguide/docs.css
  7. Verify that the CSS is valid

@zastrow zastrow force-pushed the issue-68--state-classes branch from 7b8ee42 to d34bf20 Compare January 25, 2021 14:31
Copy link
Contributor

@mdt2 mdt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THCWW5R3g5DtpVQFSD

@mdt2 mdt2 merged commit d34bf20 into main Feb 17, 2021
@mdt2 mdt2 deleted the issue-68--state-classes branch February 17, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants