Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added react router in App.tsx #400

Closed
wants to merge 2 commits into from
Closed

Added react router in App.tsx #400

wants to merge 2 commits into from

Conversation

Maaz4324
Copy link

@Maaz4324 Maaz4324 commented Oct 7, 2022

I didn't find any page to navigate so I just declared the element in Route to div

@yosevu
Copy link
Contributor

yosevu commented Oct 7, 2022

Thanks @Maaz4324! I'll take a look.

@yosevu yosevu self-requested a review October 7, 2022 23:21
yosevu
yosevu suggested changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@yosevu yosevu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Maaz4324, thanks for getting started on this!

I updated the requirements for this in issue #398. It has all the routes for the app. Would you mind stubbing them out like you did here with divs?

yosevu
yosevu reviewed Oct 9, 2022
View reviewed changes
src/App.tsx
<div className="">hello sparkeats</div>
<Router>
<div className="">hello sparkeats</div>
<nav>
Copy link
Contributor

@yosevu yosevu Oct 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait to add a nav in #401 to Rebuild the Header.

@yosevu yosevu linked an issue Oct 9, 2022 that may be closed by this pull request
Add React Router and Routes #398
Closed
@yosevu yosevu mentioned this pull request Oct 9, 2022
Closed
@yosevu
Copy link
Contributor

yosevu commented Oct 11, 2022

I had to go ahead and complete this issue in #412 @Maaz4324 since other issues depend on it. I used this PR as a reference though. Thank you and feel free to pick up another issue if you are interested!

@yosevu yosevu closed this Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosevu yosevu yosevu requested changes

Assignees

@Maaz4324 Maaz4324

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add React Router and Routes
2 participants
@Maaz4324 @yosevu