Skip to content

Commit

Permalink
feat: SiteHeader has been rebuilt
Browse files Browse the repository at this point in the history
The SiteHeader component has been migrated from the old design.

Updated some scss file names for a more consistent naming convention.

Closes #401
  • Loading branch information
catheraaine committed Oct 18, 2022
1 parent d4ab707 commit 1875e02
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/App.scss
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
// 6. Components
// Specific UI components. This is where majority of our work takes place
// and our UI components are often composed of Objects and Components
@import 'scss/components/sparkeats-header';
@import 'scss/components/site-header';
@import 'scss/components/buttons';
@import 'scss/components/place-card';
@import 'scss/components/stars';
Expand Down
3 changes: 2 additions & 1 deletion src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { Outlet } from 'react-router-dom'
import './App.scss'
import { SiteHeader } from './components/SiteHeader';

function App() {
return (
<div>
<header>Site Header</header>
<SiteHeader />
<Outlet />
</div>
)
Expand Down
9 changes: 9 additions & 0 deletions src/components/SiteHeader.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
export const SiteHeader = () => {
return (
<header className="site-header">
<h1 className="site-header__title">Sparkeats by Sparkbox</h1>
<a className="site-header__logo" href="/" aria-label="Return to Sparkeats Homepage" />
</header>
);
};

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
.sparkeats-header {
.site-header {
background-color: $primary-color;
padding: 1em;
box-sizing: border-box;
Expand Down

0 comments on commit 1875e02

Please sign in to comment.