Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests #28

Open
1 task done
bryanbraun opened this issue Feb 15, 2016 · 0 comments
Open
1 task done

Improve tests #28

bryanbraun opened this issue Feb 15, 2016 · 0 comments

Comments

@bryanbraun
Copy link
Contributor

bryanbraun commented Feb 15, 2016 •
edited
Loading

Just a few thoughts I had while looking at this.

  • We could use more tests... especially covering the core functionality. For example:
    1. Verify that when the media query enters X that "entry" methods are run.
    2. Verify that when the media query exits X that "exit" methods are run.
    3. Verify that when the media query enters or exits X that "both" methods are run.
  • It would be nice if PRs made to this repo automatically ran the tests using something like TravisCI. You could set that up using something like this: https://gist.github.com/bryanbraun/4a955cc30c394f137b0d
    • Update: this is now set up with CircleCI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robtarr @bryanbraun