Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove deprecated bottle :unneeded #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timbeadle
Copy link

Remove bottle :unneeded from brew formula.

bottle :unneeded now provokes a warning from Homebrew: Warning: Calling bottle :unneeded is deprecated! There is no replacement.

Homebrew apparently deprecated bottle :unneeded in Homebrew/brew@f65d525

@timbeadle
Copy link
Author

@bryanbraun Would you be ok to review this PR pls?

@nitrocode
Copy link

nitrocode commented Jun 26, 2022

Is this why brew tap sparkbox/commit-colors fails ?

Yep, just tested it and that's why it fails. I was able to get it working using the following.

mkdir -p /usr/local/Homebrew/Library/Taps/sparkbox/
git clone [email protected]:sparkbox/homebrew-commit-colors.git /usr/local/Homebrew/Library/Taps/sparkbox/homebrew-commit-colors
brew search commit-colors
brew install commit-colors

There's also a new generic homebrew tap repo for sparkbox where this formula could be migrated. The current sb formula there was added recently by @robtarr and doesn't contain the deprecated bottle :unneeded argument.

https://github.com/sparkbox/homebrew-brew

I added a PR for it here sparkbox/homebrew-brew#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants